Skip to content

Add TcpStream::set_linger and TcpStream::linger #88495

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Aug 31, 2021

Conversation

ibraheemdev
Copy link
Member

Adds methods for getting/setting the SO_LINGER option on TCP sockets. Behavior is consistent across Unix and Windows.

r? @joshtriplett (I noticed you've been reviewing net related PRs)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2021
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@ibraheemdev ibraheemdev force-pushed the tcp-linger branch 2 times, most recently from ceddc19 to 3b6777f Compare August 30, 2021 17:40
@joshtriplett
Copy link
Member

LGTM, r=me once CI passes.

@ibraheemdev
Copy link
Member Author

CI passed.

@joshtriplett
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 30, 2021

📌 Commit dafc147 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2021
Co-authored-by: Mara Bos <m-ou.se@m-ou.se>
@m-ou-se
Copy link
Member

m-ou-se commented Aug 31, 2021

@bors r=joshtriplett

@bors
Copy link
Collaborator

bors commented Aug 31, 2021

📌 Commit 072e8c9 has been approved by joshtriplett

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 31, 2021
Rollup of 10 pull requests

Successful merges:

 - rust-lang#85017 (Add carrying_add, borrowing_sub, widening_mul, carrying_mul methods to integers)
 - rust-lang#86362 (Avoid cloning LocalDecls)
 - rust-lang#88391 (Fix json tuple struct enum variant )
 - rust-lang#88399 (Disallow the aapcs CC on Aarch64)
 - rust-lang#88418 (Allow `~const` bounds on trait assoc functions)
 - rust-lang#88445 (Clean up the lowering of AST items)
 - rust-lang#88495 (Add `TcpStream::set_linger` and `TcpStream::linger`)
 - rust-lang#88501 (Use right span in prelude collision suggestions with macros. )
 - rust-lang#88504 (Keep turbofish in prelude collision lint.)
 - rust-lang#88524 (Remove unnecessary `mut` from udp doctests)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c5a34d8 into rust-lang:master Aug 31, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 31, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants