Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(rustc_typeck): produce better errors for dyn auto trait #88525

Merged
merged 3 commits into from
Sep 1, 2021
Merged

fix(rustc_typeck): produce better errors for dyn auto trait #88525

merged 3 commits into from
Sep 1, 2021

Conversation

notriddle
Copy link
Contributor

Fixes #85026

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 31, 2021
@notriddle notriddle force-pushed the notriddle/coherence-dyn-auto-trait branch from b2a8f6d to 026322c Compare August 31, 2021 05:15
@petrochenkov
Copy link
Contributor

r=me with the wording change.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2021
@notriddle @petrochenkov
Change wording to less jaron-y "non-auto trait"
6e70678 
Co-authored-by: Vadim Petrochenkov <vadim.petrochenkov@gmail.com>
@notriddle
Copy link
Contributor Author

@petrochenkov Okay, the wording changes are in.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Aug 31, 2021

📌 Commit 6e70678 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 31, 2021
@m-ou-se m-ou-se mentioned this pull request Sep 1, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 1, 2021
@bors
Auto merge of rust-lang#88556 - m-ou-se:rollup-q636wyd, r=m-ou-se
3ed6c1d 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#86376 (Emit specific warning to clarify that `#[no_mangle]` should not be applied on foreign statics or functions)
 - rust-lang#88040 (BTree: remove Ord bound from new)
 - rust-lang#88053 (Fix the flock fallback implementation)
 - rust-lang#88350 (add support for clobbering xer, cr, and cr[0-7] for asm! on OpenPower/PowerPC)
 - rust-lang#88410 (Remove bolding on associated constants)
 - rust-lang#88525 (fix(rustc_typeck): produce better errors for dyn auto trait)
 - rust-lang#88542 (Use the return value of readdir_r() instead of errno)
 - rust-lang#88548 (Stabilize `Iterator::intersperse()`)
 - rust-lang#88551 (Stabilize `UnsafeCell::raw_get()`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bbc94ed into rust-lang:master Sep 1, 2021
@rustbot rustbot added this to the 1.56.0 milestone Sep 1, 2021
@notriddle notriddle deleted the notriddle/coherence-dyn-auto-trait branch September 1, 2021 14:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.

impl dyn Trait on an auto trait produces a confusing diagnostic
6 participants
@notriddle @rust-highfive @petrochenkov @bors @GuillaumeGomez @rustbot