Skip to content

Detect bare blocks with type ascription that were meant to be a struct literal #88598

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2021
Merged

Detect bare blocks with type ascription that were meant to be a struct literal #88598

merged 1 commit into from
Sep 4, 2021

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Sep 2, 2021

Address part of #34255.

Potential improvement: silence the other knock down errors in issue-34255-1.rs.

@rust-highfive
Copy link
Contributor

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2021
@estebank
Copy link
Contributor Author

estebank commented Sep 2, 2021

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

# to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 2, 2021
@bors

This comment has been minimized.

# to view
@rust-log-analyzer

This comment has been minimized.

# to view
@estebank estebank force-pushed the type-ascription-can-die-in-a-fire branch from 07a7d72 to 9781a0a Compare September 2, 2021 19:11
@estebank

This comment has been minimized.

# to view
@rust-timer

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@rust-log-analyzer

This comment has been minimized.

# to view
@rust-log-analyzer

This comment has been minimized.

# to view
@bors

This comment has been minimized.

# to view
@rust-timer
Copy link
Collaborator

Queued f35a12f4e72037d59a7e2107e4f94a74437bec6c with parent 1cf8fdd, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (f35a12f4e72037d59a7e2107e4f94a74437bec6c): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 3, 2021
@estebank estebank force-pushed the type-ascription-can-die-in-a-fire branch from 9781a0a to 6d45a1a Compare September 3, 2021 14:40
@estebank
Detect bare blocks with type ascription that were meant to be a `stru…
12ce6e9 
…ct` literal

Address part of rust-lang#34255.

Potential improvement: silence the other knock down errors in
`issue-34255-1.rs`.
@estebank estebank force-pushed the type-ascription-can-die-in-a-fire branch from 6d45a1a to 12ce6e9 Compare September 3, 2021 14:43
wesleywiser
wesleywiser approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@wesleywiser
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 3, 2021

📌 Commit 12ce6e9 has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2021
@bors
Copy link
Collaborator

bors commented Sep 4, 2021

⌛ Testing commit 12ce6e9 with merge b4e8596...

@bors
Copy link
Collaborator

bors commented Sep 4, 2021

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing b4e8596 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 4, 2021
@bors bors merged commit b4e8596 into rust-lang:master Sep 4, 2021
@rustbot rustbot added this to the 1.56.0 milestone Sep 4, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@wesleywiser wesleywiser

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.56.0
Development

Successfully merging this pull request may close these issues.
7 participants
@estebank @rust-highfive @rust-timer @bors @rust-log-analyzer @wesleywiser @rustbot