-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Workaround blink/chromium grid layout limitation of 1000 rows #88776
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Workaround blink/chromium grid layout limitation of 1000 rows #88776
Conversation
See rust-lang#88545 for more details
Waiting for then CI then I r+ it. |
@bors: r+ rollup |
📌 Commit 0bf16af has been approved by |
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
Thanks! |
You are welcome! |
I tested the workaround with IE Edge 92 and Chrome 93 and it works okay. |
Good point, let's nominate it for beta backport. Do you accept this to be backported to beta @rust-lang/rustdoc? |
Was the issue a beta regression? |
I think it reached the 1.56 beta version, so yes, it's a regression. |
I was more wondering whether it was not already in stable, looking back at the history I assume #85651 introduced the issue? That is on 1.55, but maybe it's worth a beta backport to only have a single version with the problem. |
Yes it's the one. |
Unfortunately it has reached stable too: https://doc.rust-lang.org/beta/core/arch/arm/index.html |
Ah damn... Oh well, at least it'll only be one version with this issue... |
If there is a 1.55.1 release we could backport the workaround there too |
…arth Rollup of 15 pull requests Successful merges: - rust-lang#85200 (Ignore derived Clone and Debug implementations during dead code analysis) - rust-lang#86165 (Add proc_macro::Span::{before, after}.) - rust-lang#87088 (Fix stray notes when the source code is not available) - rust-lang#87441 (Emit suggestion when passing byte literal to format macro) - rust-lang#88546 (Emit proper errors when on missing closure braces) - rust-lang#88578 (fix(rustc): suggest `items` be borrowed in `for i in items[x..]`) - rust-lang#88632 (Fix issues with Markdown summary options) - rust-lang#88639 (rustdoc: Fix ICE with `doc(hidden)` on tuple variant fields) - rust-lang#88667 (Tweak `write_fmt` doc.) - rust-lang#88720 (Rustdoc coverage fields count) - rust-lang#88732 (RustWrapper: avoid deleted unclear attribute methods) - rust-lang#88742 (Fix table in docblocks) - rust-lang#88776 (Workaround blink/chromium grid layout limitation of 1000 rows) - rust-lang#88807 (Fix typo in docs for iterators) - rust-lang#88812 (Fix typo `option` -> `options`.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Should I open a PR with this commit on the beta branch too? |
Yes please. :) |
…ation of 1000 rows See rust-lang#88545 for more details
Done :) Could you move the beta-nominated label to the new PR? |
This is not how beta nominations work. Please use the existing process so the release team can keep track of which PRs have been backported and which haven't. |
Very sorry. I renamed the other PR, but I am not sure If I should be reopened ir or if someone else will cherrypick one of the PRs or me doing nothing? |
@dns2utf8 it's ok, that's why there's docs :) if you want to make a backport PR that's fine, but please include all the other beta accepted PRs at the same time, and ask a member of T-release to review, not Guillaume. |
It's probably best to just wait for T-release to backport this PR with the other beta backports. Someone from T-release goes through and backports beta-accepted PRs periodically. |
[beta] backports - rustdoc: Fix ICE with `doc(hidden)` on tuple variant fields rust-lang#88639 - Fix 2021 `dyn` suggestion that used code as label rust-lang#88657 - Workaround blink/chromium grid layout limitation of 1000 rows rust-lang#88776 - Change scope of temporaries in match guards rust-lang#88678 - Add a regression test for rust-lang#88649 rust-lang#88691 - Revert anon union parsing rust-lang#88775 - Disable validate_maintainers. rust-lang#88977 Also drop stage0 rustfmt, because that's only supposed to be used on master. r? `@Mark-Simulacrum`
…nts, r=GuillaumeGomez Rustdoc migrate to table so the gui can handle >2k constants Closes rust-lang#88545. This PR adds a test for overlapping entries in the `item-table` rust-lang#88545 It currently includes the commit with the workaround from rust-lang#88776
…nts, r=GuillaumeGomez Rustdoc migrate to table so the gui can handle >2k constants Closes rust-lang#88545. This PR adds a test for overlapping entries in the `item-table` rust-lang#88545 It currently includes the commit with the workaround from rust-lang#88776
I made this in case we don't come up with a better solution in time.
See #88545 for more details.
A rendered version of the standard library is hosted here:
https://data.estada.ch/rustdoc-nightly_497ee321af_2021-09-09/core/arch/arm/index.html
r? @GuillaumeGomez @jsha