Allow panic!("{}", computed_str) in const fn.
#88954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-const-eval
rust-highfive
added
the
S-waiting-on-review
|
looks good from the @rust-lang/wg-const-eval perspective r? @m-ou-se |
RalfJung
reviewed
Sep 15, 2021
RalfJung
reviewed
Sep 15, 2021
RalfJung
reviewed
Sep 15, 2021
m-ou-se
reviewed
Sep 15, 2021
|
@bors r+ |
|
📌 Commit 11c0e58 has been approved by |
bors
added
S-waiting-on-bors
|
@nbdd0121 Thanks for making this happen! 🎉 |
|
new attempt at stabilization: #89006 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 17, 2021
…laumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#86422 (Emit clearer diagnostics for parens around `for` loop heads) - rust-lang#87460 (Point to closure when emitting 'cannot move out' for captured variable) - rust-lang#87566 (Recover invalid assoc type bounds using `==`) - rust-lang#88666 (Improve build command for compiler docs) - rust-lang#88899 (Do not issue E0071 if a type error has already been reported) - rust-lang#88949 (Fix handling of `hir::GenericArg::Infer` in `wrong_number_of_generic_args.rs`) - rust-lang#88953 (Add chown functions to std::os::unix::fs to change the owner and group of files) - rust-lang#88954 (Allow `panic!("{}", computed_str)` in const fn.) - rust-lang#88964 (Add rustdoc version into the help popup) - rust-lang#89012 (Suggest removing `#![feature]` for library features that have been stabilized) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
94 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special-case
panic!("{}", arg)and translate it topanic_display(&arg).panic_displaywill behave likepanic_anyin cosnt eval and behave likepanic!(format_args!("{}", arg))in runtime.This should bring Rust 2015 and 2021 to feature parity in terms of
const_panic; and hopefully would unblock the stabilisation of #51999.@rustbot modify labels: +T-compiler +T-libs +A-const-eval +A-const-fn
r? @oli-obk