Skip to content

Rollup of 10 pull requests #89019

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 23 commits into from
Sep 16, 2021
Merged

Rollup of 10 pull requests #89019

merged 23 commits into from
Sep 16, 2021

Conversation

Manishearth
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

estebank and others added 23 commits September 7, 2021 17:45
Detect likely `struct` literal using parentheses as delimiters and emit
targeted suggestion instead of type ascription parse error.

Fix rust-lang#61326.
…nimplemented

This isn't allowed by the validator, and seems to be unused.
When it was added in ed10a3f,
it was used on `Sized`, and that usage is gone.
rust-lang/backtrace-rs#437 fixed backtraces in
OpenBSD -> update it here as well so OpenBSD Rust code can produce
proper backtraces.
…yn514

Enable --generate-link-to-definition for rustc's docs

cc `@jyn514`
…s, r=oli-obk

Recover from `Foo(a: 1, b: 2)`

Detect likely `struct` literal using parentheses as delimiters and emit
targeted suggestion instead of type ascription parse error.

Fix rust-lang#61326.
…trait-selection, r=Mark-Simulacrum

cleanup(rustc_trait_selection): remove vestigial code from rustc_on_unimplemented

This isn't allowed by the validator, and seems to be unused.
When it was added in ed10a3f,
it was used on `Sized`, and that usage is gone.
Move object safety suggestions to the end of the error
Document the closure arguments for `reduce`.

See issue rust-lang#88927.
…ocs, r=Mark-Simulacrum

Clean up and add doc comments for CStr

CC rust-lang#51430
…call, r=ecstatic-morse

Allow calling `get_body_with_borrowck_facts` without `-Z polonius`

For my [static analysis tool](https://github.com/willcrichton/flowistry), I need to access the set of outlives-constraints. Recently, rust-lang#86977 merged a way to access these facts via Polonius. However, the merged implementation requires `-Z polonius` to be provided to use this feature. This uses Polonius for borrow checking on the entire crate, which as described [here](https://rust-lang.zulipchat.com/#narrow/stream/186049-t-compiler.2Fwg-polonius/topic/Polonius.20performance.20in.20a.20rustc.20plugin/near/251301631), is very slow.

This PR allows `get_body_with_borrowck_facts` to be called without `-Z polonius`. This is essential for my tool to run in a sensible length of time. This is a temporary patch as the Polonius-related APIs develop -- I can update my code as future changes happen.

Additionally, this PR also makes public two APIs that were previously public but then became private after `rustc_mir` got broken up: `rustc_mir_dataflow::framework::graphviz` and `rustc_mir_transform::MirPass`. I need both of these for my analysis tool. (I can break this change into a separate PR if necessary.)
Update clobber_abi list to include k[1-7] regs
Update the backtrace crate

rust-lang/backtrace-rs#437 fixed backtraces in
OpenBSD -> update it here as well so OpenBSD Rust code can produce
proper backtraces.
@rustbot rustbot added the rollup A PR which is a rollup label Sep 16, 2021
@Manishearth
Copy link
Member Author

@bors r+ p=3 rollup=never

@bors
Copy link
Collaborator

bors commented Sep 16, 2021

📌 Commit d9fa356 has been approved by Manishearth

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 16, 2021
@bors
Copy link
Collaborator

bors commented Sep 16, 2021

⌛ Testing commit d9fa356 with merge e4828d5...

@bors
Copy link
Collaborator

bors commented Sep 16, 2021

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing e4828d5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 16, 2021
@bors bors merged commit e4828d5 into rust-lang:master Sep 16, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 16, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants