Skip to content

Resolve issue : Somewhat confusing error with extended_key_value_attributes #89023

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2021
Merged

Resolve issue : Somewhat confusing error with extended_key_value_attributes #89023

merged 1 commit into from
Sep 24, 2021

Conversation

Wardenfar
Copy link
Contributor

@Wardenfar Wardenfar commented Sep 16, 2021 •
edited
Loading

Fixes #85066

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 16, 2021
nagisa
nagisa reviewed Sep 17, 2021
View reviewed changes
@nagisa
Copy link
Member

nagisa commented Sep 18, 2021

Please squash the commits in order to retain a clean history after the merge happens.

@camelid
Copy link
Member

camelid commented Sep 18, 2021

@Wardenfar If you edit the PR description to be Fixes #85066., GitHub will automatically close the issue when this PR is merged.

@camelid camelid added A-parser Area: The lexing & parsing of Rust source code to an AST S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2021
@Wardenfar
Copy link
Contributor Author

@nagisa I have tried to sqash tell me if it is right
@camelid i have changed the description of the PR

@nagisa
Copy link
Member

nagisa commented Sep 18, 2021

@bors r+ thanks!

@bors
Copy link
Collaborator

bors commented Sep 18, 2021

📌 Commit 59d5eb2 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 18, 2021
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Sep 19, 2021
@JohnTitor
Rollup merge of rust-lang#89023 - Wardenfar:issue-85066, r=nagisa
833312b 
Resolve issue 85066

Fixes rust-lang#85066
@JohnTitor JohnTitor mentioned this pull request Sep 19, 2021
Closed
@JohnTitor
Copy link
Member

Failed in rollup: #89087 (comment)
@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2021
@Wardenfar
Resolve issue 85066
250a3e4 
Fix : use struct_dummy

Fix different os messages
@Wardenfar
Copy link
Contributor Author

@JohnTitor i think i fixed it

@nagisa
Copy link
Member

nagisa commented Sep 19, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 19, 2021

📌 Commit 250a3e4 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 19, 2021
@the8472
Copy link
Member

the8472 commented Sep 22, 2021

This PR could use a better title

@Wardenfar Wardenfar changed the title Resolve issue 85066 Resolve issue : Somewhat confusing error with extended_key_value_attributes Sep 22, 2021
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Sep 23, 2021
@workingjubilee
Rollup merge of rust-lang#89023 - Wardenfar:issue-85066, r=nagisa
e9d1d12 
Resolve issue : Somewhat confusing error with extended_key_value_attributes

Fixes rust-lang#85066
This was referenced Sep 23, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 24, 2021
@bors
Auto merge of rust-lang#89211 - workingjubilee:rollup-fj4eduk, r=work…
293b8f2 
…ingjubilee

Rollup of 7 pull requests

Successful merges:

 - rust-lang#88612 (Add a better error message for rust-lang#39364)
 - rust-lang#89023 (Resolve issue : Somewhat confusing error with extended_key_value_attributes)
 - rust-lang#89148 (Suggest `_` in turbofish if param will be inferred from fn argument)
 - rust-lang#89171 (Run `no_core` rustdoc tests only on Linux)
 - rust-lang#89176 (Change singular to plural)
 - rust-lang#89184 (Temporarily rename int_roundings functions to avoid conflicts)
 - rust-lang#89200 (Fix typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5da2f46 into rust-lang:master Sep 24, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 24, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nagisa nagisa nagisa left review comments

Assignees

@nagisa nagisa

Labels
A-parser Area: The lexing & parsing of Rust source code to an AST S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.

Somewhat confusing error with extended_key_value_attributes
8 participants
@Wardenfar @rust-highfive @nagisa @camelid @bors @JohnTitor @the8472 @rustbot