Skip to content

Update stdarch submodule #89145

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2021
Merged

Update stdarch submodule #89145

merged 1 commit into from
Sep 27, 2021

Conversation

hkratz
Copy link
Contributor

@hkratz hkratz commented Sep 21, 2021 •
edited
Loading

This is mainly to fix the critical issue of aarch64 store intrinsics overwriting additional memory, see rust-lang/stdarch#1220

Changes:

@hkratz
Update stdarch submodule
1afb537 
This mainly fixes the critical issue of aarch64 store intrinsics
overwriting additional memory, see
rust-lang/stdarch#1220

Other changes:
* aarch64/armv7: additional vld1/vst1 intrinsics + perf fixes for existing ones
* armv7: Make FMA work with vfpv4
* Non-visible changes to the testing framework
@rust-highfive
Copy link
Contributor

r? @kennytm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 21, 2021
@kennytm
Copy link
Member

kennytm commented Sep 21, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Sep 21, 2021

📌 Commit 1afb537 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2021
@HEnquist HEnquist mentioned this pull request Sep 24, 2021
Merged
@bors
Copy link
Collaborator

bors commented Sep 27, 2021

⌛ Testing commit 1afb537 with merge c81c3ea...

@bors
Copy link
Collaborator

bors commented Sep 27, 2021

☀️ Test successful - checks-actions
Approved by: kennytm
Pushing c81c3ea to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 27, 2021
@bors bors merged commit c81c3ea into rust-lang:master Sep 27, 2021
@rustbot rustbot added this to the 1.57.0 milestone Sep 27, 2021
@pthariensflame pthariensflame mentioned this pull request Sep 27, 2021
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c81c3ea): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@hkratz hkratz deleted the bump_stdarch branch November 6, 2021 20:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.57.0
Development

Successfully merging this pull request may close these issues.
6 participants
@hkratz @rust-highfive @kennytm @bors @rust-timer @rustbot