Skip to content

Add deref_into_dyn_supertrait lint. #89461

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

crlf0710
Copy link
Member

@crlf0710 crlf0710 commented Oct 2, 2021

Initial implementation of #89460. Resolves #89190.
Maybe also worth a beta backport if necessary.

r? @nikomatsakis

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 2, 2021
@crlf0710 crlf0710 force-pushed the dyn_upcasting_lint branch from b764994 to ff2d735 Compare October 2, 2021 11:27
@rust-log-analyzer

This comment has been minimized.

@crlf0710 crlf0710 force-pushed the dyn_upcasting_lint branch from ff2d735 to 3b117b3 Compare October 3, 2021 04:28
@crlf0710 crlf0710 added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. F-trait_upcasting `#![feature(trait_upcasting)]` labels Oct 3, 2021
@crlf0710 crlf0710 force-pushed the dyn_upcasting_lint branch from 3b117b3 to 250d126 Compare October 3, 2021 04:36
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 6, 2021

📌 Commit 250d126 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 7, 2021
…laumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#89298 (Issue 89193 - Fix ICE when using `usize` and `isize` with SIMD gathers )
 - rust-lang#89461 (Add `deref_into_dyn_supertrait` lint.)
 - rust-lang#89477 (Move items related to computing diffs to a separate file)
 - rust-lang#89559 (RustWrapper: adapt for LLVM API change)
 - rust-lang#89585 (Emit item no type error even if type inference fails)
 - rust-lang#89596 (Make cfg imply doc(cfg))
 - rust-lang#89615 (Add InferCtxt::with_opaque_type_inference to get_body_with_borrowck_facts)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ab276b8 into rust-lang:master Oct 7, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 7, 2021
@crlf0710 crlf0710 deleted the dyn_upcasting_lint branch October 8, 2021 08:44
@pnkfelix pnkfelix added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Nov 16, 2021
@pnkfelix
Copy link
Member

(This is already in the 1.57-beta, according to discussion on #89190. So I'll just stable-nominate it.)

@pnkfelix pnkfelix added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Nov 16, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 18, 2021
@apiraino
Copy link
Contributor

Stable backport declined as per compiler team on Zulip

@rustbot label -stable-nominated

@rustbot rustbot removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Nov 18, 2021
Tamschi added a commit to Tamschi/fruit-salad that referenced this pull request Nov 18, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. F-trait_upcasting `#![feature(trait_upcasting)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trait upcasting shadows (trait object) deref coercion
9 participants