Skip to content

refactor: VecDeques Iter fields to private #89685

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 31, 2022
Merged

refactor: VecDeques Iter fields to private #89685

merged 1 commit into from
May 31, 2022

Conversation

DeveloperC286
Copy link
Contributor

Made the fields of VecDeque's Iter private by creating a Iter::new(...) function to create a new instance of Iter and migrating usage to use Iter::new(...).

@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2021
@the8472 the8472 added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 11, 2021
@jyn514 jyn514 added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Nov 9, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2022
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2022
@Dylan-DPC
Copy link
Member

@joshtriplett this is ready for review

@DeveloperC286
Copy link
Contributor Author

Rebased 👍

@bors
Copy link
Collaborator

bors commented Mar 11, 2022

☔ The latest upstream changes (presumably #94472) made this pull request unmergeable. Please resolve the merge conflicts.

Made the fields of VecDeque's Iter private by creating a Iter::new(...) function to create a new instance of Iter and migrating usage to use Iter::new(...).
@DeveloperC286
Copy link
Contributor Author

Rebased and resolved conflict.

@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2022
@oli-obk
Copy link
Contributor

oli-obk commented May 30, 2022

r? @oli-obk

@bors r+ rollup

Thanks! Sorry this took so long, some things disappear in a notification hole and we need to dig them out again

@bors
Copy link
Collaborator

bors commented May 30, 2022

📌 Commit cf30ac8 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2022
compiler-errors added a commit to compiler-errors/rust that referenced this pull request May 30, 2022
…e, r=oli-obk

refactor: VecDeques Iter fields to private

Made the fields of VecDeque's Iter private by creating a Iter::new(...) function to create a new instance of Iter and migrating usage to use Iter::new(...).
bors added a commit to rust-lang-ci/rust that referenced this pull request May 31, 2022
…piler-errors

Rollup of 6 pull requests

Successful merges:

 - rust-lang#89685 (refactor: VecDeques Iter fields to private)
 - rust-lang#97172 (Optimize the diagnostic generation for `extern unsafe`)
 - rust-lang#97395 (Miri call ABI check: ensure type size+align stay the same)
 - rust-lang#97431 (don't do `Sized` and other return type checks on RPIT's real type)
 - rust-lang#97555 (Source code page: line number click adds `NaN`)
 - rust-lang#97558 (Fix typos in comment)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3c0b9d5 into rust-lang:master May 31, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 31, 2022
@DeveloperC286 DeveloperC286 deleted the iter_fields_to_private branch July 20, 2022 09:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants