Move DebuggerCommands and check_debugger_output to a separate module
#89691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Nicholas-Baron
force-pushed
the
debugger_commands
branch
from
89727da to
2d827ca
Compare
|
@bors r+ rollup |
|
📌 Commit 2d827ca has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 11, 2021
…askrgr Rollup of 6 pull requests Successful merges: - rust-lang#89579 (Add regression test for issue 80108) - rust-lang#89632 (Fix docblock code display on mobile) - rust-lang#89691 (Move `DebuggerCommands` and `check_debugger_output` to a separate module) - rust-lang#89707 (Apply clippy suggestions for std) - rust-lang#89722 (Fix spelling: Cannonical -> Canonical) - rust-lang#89736 (Remove unused CSS rule) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #89475.
As part of this move, the public functions were changed to return
Result. This is so that the error handling that initially took&self: TestCxcan still use thatTestCx.