Add #[must_use] to to_value conversions #89794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jkugelman
force-pushed
the
must-use-to_value-conversions
branch
from
b142b8f to
0cf84c8
Compare
|
For the methods that consume self, "without modifying the original" seems misleading. Perhaps something like "consume the value and return a new value, rather than modifying the original in-place"? |
joshtriplett
added
the
relnotes
|
The ones that take |
|
Fair enough. @bors r+ |
|
📌 Commit 0cf84c8 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 13, 2021
…ions, r=joshtriplett Add #[must_use] to to_value conversions `NonNull<T>::cast` snuck in when I wasn't looking. What a scamp! Parent issue: rust-lang#89692 r? ``@joshtriplett``
the8472
added a commit
to the8472/rust
that referenced
this pull request
Oct 13, 2021
…ions, r=joshtriplett Add #[must_use] to to_value conversions `NonNull<T>::cast` snuck in when I wasn't looking. What a scamp! Parent issue: rust-lang#89692 r? ```@joshtriplett```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 13, 2021
Rollup of 12 pull requests Successful merges: - rust-lang#89768 (add some more testcases) - rust-lang#89777 (Edit explanation of test for nested type ascriptions) - rust-lang#89781 (Add missing words in `Infallible` docs) - rust-lang#89782 (Improve CJK font in rustdoc) - rust-lang#89794 (Add #[must_use] to to_value conversions) - rust-lang#89814 (Fix uppercase/lowercase error) - rust-lang#89816 (Fix invalid rules in .gitignore) - rust-lang#89817 (Add #[inline] to int log10 functions.) - rust-lang#89818 (Use Option::map_or instead of open coding it) - rust-lang#89828 (Fix config.toml overflow-checks options) - rust-lang#89840 (fix the stage0 tools config file path in `config.toml.example`) - rust-lang#89845 (Add davidtwco to the `.mailmap`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NonNull<T>::castsnuck in when I wasn't looking. What a scamp!Parent issue: #89692
r? @joshtriplett