Add #[must_use] to non-mutating verb methods #89796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
jkugelman
force-pushed
the
must-use-non-mutating-verb-methods
branch
from
31c9232 to
c3f0577
Compare
joshtriplett
added
the
relnotes
|
@bors r+ |
|
📌 Commit c3f0577 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 12, 2021
…b-methods, r=joshtriplett Add #[must_use] to non-mutating verb methods These are methods that could be misconstrued to mutate their input, similar to rust-lang#89694. I gave each one a different custom message. I wrote that `upgrade` and `downgrade` don't modify the input pointers. Logically they don't, but technically they do... Parent issue: rust-lang#89692 r? `@joshtriplett`
the8472
added a commit
to the8472/rust
that referenced
this pull request
Oct 12, 2021
…b-methods, r=joshtriplett Add #[must_use] to non-mutating verb methods These are methods that could be misconstrued to mutate their input, similar to rust-lang#89694. I gave each one a different custom message. I wrote that `upgrade` and `downgrade` don't modify the input pointers. Logically they don't, but technically they do... Parent issue: rust-lang#89692 r? ``@joshtriplett``
This was referenced Oct 12, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 12, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#89778 (Add #[must_use] to as_type conversions) - rust-lang#89784 (Remove built-in query cache_hit tracking) - rust-lang#89796 (Add #[must_use] to non-mutating verb methods) - rust-lang#89797 (Add #[must_use] to is_condition tests) - rust-lang#89799 (fix minor spelling error in Poll::ready docs) - rust-lang#89800 (Update books) - rust-lang#89809 (Remap ssa RealPredicate to llvm RealPredicate) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
Is it intentional that |
Sure isn't. Submitted #89833. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 31, 2021
…joshtriplett Add #[must_use] to Rc::downgrade Missed this in previous PR rust-lang#89796 (comment) Parent issue: rust-lang#89692 r? `@joshtriplett`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 31, 2021
…joshtriplett Add #[must_use] to Rc::downgrade Missed this in previous PR rust-lang#89796 (comment) Parent issue: rust-lang#89692 r? ``@joshtriplett``
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 31, 2021
…joshtriplett Add #[must_use] to Rc::downgrade Missed this in previous PR rust-lang#89796 (comment) Parent issue: rust-lang#89692 r? ```@joshtriplett```
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are methods that could be misconstrued to mutate their input, similar to #89694. I gave each one a different custom message.
I wrote that
upgradeanddowngradedon't modify the input pointers. Logically they don't, but technically they do...Parent issue: #89692
r? @joshtriplett