Skip to content

Revert "Auto merge of #89709 - clemenswasser:apply_clippy_suggestions… #89905

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2021
Merged

Revert "Auto merge of #89709 - clemenswasser:apply_clippy_suggestions… #89905

merged 1 commit into from
Oct 19, 2021

Conversation

matthiaskrgr
Copy link
Member

…_2, r=petrochenkov"

The PR had some unforseen perf regressions that are not as easy to find.
Revert the PR for now.

This reverts commit 6ae8912, reversing
changes made to 86d6d2b.

@matthiaskrgr
Revert "Auto merge of rust-lang#89709 - clemenswasser:apply_clippy_su…
4457014 
…ggestions_2, r=petrochenkov"

The PR had some unforseen perf regressions that are not as easy to find.
Revert the PR for now.

This reverts commit 6ae8912, reversing
changes made to 86d6d2b.
@rust-highfive
Copy link
Contributor

Changes rustc_apfloat. rustc_apfloat is currently in limbo and you almost certainly don't want to change it (see #55993).

cc @eddyb

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 15, 2021
@matthiaskrgr
Copy link
Member Author

@bors rollup=never

@eddyb eddyb mentioned this pull request Oct 15, 2021
Merged
@michaelwoerister
Copy link
Member

Thanks @matthiaskrgr
@bors r+

@bors
Copy link
Collaborator

bors commented Oct 18, 2021

📌 Commit 4457014 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2021
@bors
Copy link
Collaborator

bors commented Oct 19, 2021

⌛ Testing commit 4457014 with merge cd8b56f...

@bors
Copy link
Collaborator

bors commented Oct 19, 2021

☀️ Test successful - checks-actions
Approved by: michaelwoerister
Pushing cd8b56f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 19, 2021
@bors bors merged commit cd8b56f into rust-lang:master Oct 19, 2021
@rustbot rustbot added this to the 1.58.0 milestone Oct 19, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cd8b56f): comparison url.

Summary: This change led to large relevant improvements 🎉 in compiler performance.

  • Large improvement in instruction counts (up to -3.3% on full builds of inflate)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

@matthiaskrgr matthiaskrgr deleted the rev_89709_entirely branch January 25, 2025 09:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@michaelwoerister michaelwoerister michaelwoerister approved these changes

Assignees

@michaelwoerister michaelwoerister

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.
6 participants
@matthiaskrgr @rust-highfive @michaelwoerister @bors @rust-timer @rustbot