-
Notifications
You must be signed in to change notification settings - Fork 13.4k
CI: make docker cache download and docker load
time out after 10 minutes
#90122
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
On second thought it seems much more likely that docker load hangs. |
This comment has been minimized.
This comment has been minimized.
93f9b91
to
3e8b7de
Compare
3e8b7de
to
838e673
Compare
@bors r+ |
📌 Commit 838e673 has been approved by |
@Mark-Simulacrum I now strongly suspect that it is We could try |
…k-Simulacrum CI: make docker cache download attempt time out after 10 minutes Might help to prevent timeouts we have been seeing: * https://github.com/rust-lang-ci/rust/runs/3946294286?check_suite_focus=true#step:25:23 * https://github.com/rust-lang-ci/rust/runs/3956799200?check_suite_focus=true#step:25:22
…k-Simulacrum CI: make docker cache download attempt time out after 10 minutes Might help to prevent timeouts we have been seeing: * https://github.com/rust-lang-ci/rust/runs/3946294286?check_suite_focus=true#step:25:23 * https://github.com/rust-lang-ci/rust/runs/3956799200?check_suite_focus=true#step:25:22 * https://github.com/rust-lang-ci/rust/runs/3962928502?check_suite_focus=true#step:25:23
docker load
time out after 10 minutes
Adding timeout for |
83fb7ec
to
f6dec14
Compare
f6dec14
to
3e6a695
Compare
@rustbot label -S-waiting-on-bors +S-waiting-on-review |
@bors r+ rollup |
📌 Commit 3e6a695 has been approved by |
…askrgr Rollup of 11 pull requests Successful merges: - rust-lang#83233 (Implement split_array and split_array_mut) - rust-lang#88300 (Stabilise unix_process_wait_more, extra ExitStatusExt methods) - rust-lang#89416 (nice_region_error: Include lifetime placeholders in error output) - rust-lang#89468 (Report fatal lexer errors in `--cfg` command line arguments) - rust-lang#89730 (add feature flag for `type_changing_struct_update`) - rust-lang#89920 (Implement -Z location-detail flag) - rust-lang#90070 (Add edition configuration to compiletest) - rust-lang#90087 (Sync rustfmt subtree) - rust-lang#90117 (Make RSplit<T, P>: Clone not require T: Clone) - rust-lang#90122 (CI: make docker cache download and `docker load` time out after 10 minutes) - rust-lang#90166 (Add comment documenting why we can't use a simpler solution) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Might help to prevent timeouts we have been seeing:
If the download or loading the images into docker times out the CI will still continue and rebuild the docker image from scratch.