-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Rollup of 3 pull requests #90217
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rollup of 3 pull requests #90217
Conversation
This fixes warning when building Rust and running tests: ``` warning: library kind `static-nobundle` has been superseded by specifying `-bundle` on library kind `static`. Try `static:-bundle` warning: `rustc_llvm` (lib) generated 2 warnings (1 duplicate) ```
Normalize MIR with RevealAll before optimizations. Fixes rust-lang#78442
Add rustc lint, warning when iterating over hashmaps r? rust-lang/wg-incr-comp
…petrochenkov Repace use of `static_nobundle` with `native_link_modifiers` within Rust codebase This fixes warnings when building Rust and running tests: ``` warning: library kind `static-nobundle` has been superseded by specifying `-bundle` on library kind `static`. Try `static:-bundle` warning: `rustc_llvm` (lib) generated 2 warnings (1 duplicate) ```
@bors r+ p=3 rollup=never |
📌 Commit 0cf784d has been approved by |
Feel free to chancel this in favor of bigger rollups if more rollupable prs get approved until ci starts processing this :) |
The problem is IMHO that rollups skip to the front of the queue and other unprioritized non-rollupable PRs get pushed back regardless of their age. If rollups don't happen too often then the trade-off of getting more PRs through is worth it but for small ones like this one not so much. Of course I might be biased currently. 🙃 |
⌛ Testing commit 0cf784d with merge 4b5561f464bf3639c592dae224d47a7d862a8518... |
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
Successful merges:
static_nobundle
withnative_link_modifiers
within Rust codebase #90205 (Repace use ofstatic_nobundle
withnative_link_modifiers
within Rust codebase)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup