Rollup of 5 pull requests #90347
Merged
Rollup of 5 pull requests #90347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n 2021 is suggested
…id getting inconsistent output between local and CI.
Consistent big O notation in map.rs Follow up to rust-lang#89216
…id_attrs_ice, r=Aaron1011 fix: inner attribute followed by outer attribute causing ICE Fixes rust-lang#87936, rust-lang#88938, and rust-lang#89971. This removes the assertion that validates that there are no outer attributes following inner attributes. Where the inner attribute is invalid you get an actual error.
…vidtwco Add hint for people missing `TryFrom`, `TryInto`, `FromIterator` import pre-2021 Adds a hint anytime a `TryFrom`, `TryInto`, `FromIterator` import is suggested noting that these traits are automatically imported in Edition 2021.
…rk-Simulacrum Add regression test for rust-lang#75961 Closes rust-lang#75961. Closes rust-lang#21203.
…ecked, r=Mark-Simulacrum Add tracking issue number to const_cstr_unchecked Also created a tracking issue, see rust-lang#90343. I think it makes sense to stabilize this somewhat soon considering abuse of `transmute` to have this feature in constants, see https://crates.io/crates/cstr for an example. Code can be rewritten to use `mem::transmute` to work on stable.
|
@bors r+ rollup=never p=5 |
|
📌 Commit 623c3e1 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (4e0d397): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
TryFrom,TryInto,FromIteratorimport pre-2021 #90288 (Add hint for people missingTryFrom,TryInto,FromIteratorimport pre-2021)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup