Skip to content

Clarify what to do with accepted feature gates #90472

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

joshtriplett
Copy link
Member

The documentation only referenced removed.rs, but feature gates for
accepted features move to accepted.rs.

The documentation only referenced `removed.rs`, but feature gates for
accepted features move to `accepted.rs`.
@rust-highfive
Copy link
Contributor

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2021
@jyn514
Copy link
Member

jyn514 commented Nov 1, 2021

Could you also link to https://rustc-dev-guide.rust-lang.org/feature-gates.html#feature-gates at the same time?

@joshtriplett
Copy link
Member Author

Done.

@jyn514
Copy link
Member

jyn514 commented Nov 2, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 2, 2021

📌 Commit eb23a73 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 2, 2021
…ance, r=jyn514

Clarify what to do with accepted feature gates

The documentation only referenced `removed.rs`, but feature gates for
accepted features move to `accepted.rs`.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 3, 2021
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#90084 (Make printed message match the code comment)
 - rust-lang#90354 (Document clippy on nightly-rustc)
 - rust-lang#90417 (stabilize `relaxed_struct_unsize`)
 - rust-lang#90472 (Clarify what to do with accepted feature gates)
 - rust-lang#90500 (Update Clippy dependencies)
 - rust-lang#90502 (Split doc_cfg and doc_auto_cfg features)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bc26dbb into rust-lang:master Nov 3, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 3, 2021
@joshtriplett joshtriplett deleted the clarify-feature-acceptance branch November 3, 2021 13:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants