Skip to content

Update cargo #90490

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Update cargo #90490

merged 1 commit into from
Nov 2, 2021

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 1, 2021

3 commits in 6c1bc24b8b49d4bc965f67d7037906dc199c72b7..94ca096afbf25f670e76e07dca754fcfe27134be
2021-10-24 17:51:41 +0000 to 2021-10-29 14:45:06 +0000

@ehuss ehuss self-assigned this Nov 1, 2021
@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Nov 1, 2021

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Nov 1, 2021

📌 Commit 6404dba has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2021
@bors
Copy link
Collaborator

bors commented Nov 2, 2021

⌛ Testing commit 6404dba with merge dca3f1b...

@bors
Copy link
Collaborator

bors commented Nov 2, 2021

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing dca3f1b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 2, 2021
@bors bors merged commit dca3f1b into rust-lang:master Nov 2, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 2, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dca3f1b): comparison url.

Summary: This change led to moderate relevant regressions 😿 in compiler performance.

  • Moderate regression in instruction counts (up to 2.0% on incr-patched: println builds of regression-31157)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

@rustbot rustbot added the perf-regression Performance regression. label Nov 2, 2021
@pnkfelix
Copy link
Member

pnkfelix commented Nov 2, 2021

Visiting for weekly performance triage

Only regression-31157 opt regressed, by 1.6-2.0%.

I don't think its worth investing effort trying to figure out the root cause of this limited regression.

(I will note that regression #31157 was itself put in to catch a performance regression with respect to time and RAM, but that regression was more like 1,882% in time and 10x in space.)

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 2, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants