Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Keep spans for generics in #[derive(_)] desugaring #90519

Merged
merged 5 commits into from
Dec 4, 2021
Merged

Keep spans for generics in #[derive(_)] desugaring #90519

merged 5 commits into from
Dec 4, 2021

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Nov 3, 2021

Keep the spans for generics coming from a derived Item, so that errors
and suggestions have better detail.

Fix #84003.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 3, 2021
@apiraino apiraino added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 11, 2021
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2021
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 17, 2021
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2021
@estebank estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 20, 2021
@estebank estebank mentioned this pull request Nov 23, 2021
Closed
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2021
@rust-log-analyzer

This comment has been minimized.

# to view
@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 2, 2021
@petrochenkov
Copy link
Contributor

Blocked on #91441.

@petrochenkov petrochenkov added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2021
@petrochenkov petrochenkov mentioned this pull request Dec 2, 2021
Closed
@petrochenkov
Copy link
Contributor

#91441 (comment), unblocking.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Dec 3, 2021
@estebank
Keep spans for generics in #[derive(_)] desugaring
e70105f 
Keep the spans for generics coming from a `derive`d Item, so that errors
and suggestions have better detail.

Fix rust-lang#84003.
@estebank
Modify bounds_span to ignore bounds coming from a derive macro
fa3eebb
@estebank
Remove some unnecessarily verbose code
8bee2b8
@estebank
Annotate derived spans and move span suggestion code
962b219 
* Annotate `derive`d spans from the user's code with the appropciate context
* Add `Span::can_be_used_for_suggestion` to query if the underlying span
  at the users' code
@estebank
Copy link
Contributor Author

estebank commented Dec 3, 2021

Updated the PR without the MutVisitor.

@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 4, 2021
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Dec 4, 2021

📌 Commit b0c3968 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 4, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 4, 2021
@bors
Auto merge of rust-lang#91517 - matthiaskrgr:rollup-3fmp4go, r=matthi…
efec545 
…askrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#87054 (Add a `try_reduce` method to the Iterator trait)
 - rust-lang#89701 (Updated error message for accidental uses of derive attribute as a crate attribute)
 - rust-lang#90519 (Keep spans for generics in `#[derive(_)]` desugaring)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0311cfa into rust-lang:master Dec 4, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 4, 2021
@fmease fmease mentioned this pull request May 24, 2022
Open
@estebank estebank deleted the issue-84003 branch November 9, 2023 05:14
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 6, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.

Misleading diagnostics with missing bounds when deriving a trait
7 participants
@estebank @rust-highfive @rust-log-analyzer @petrochenkov @bors @apiraino @rustbot