Skip to content

Update aarch64 target_feature list for LLVM 12. #90537

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

adamgemmell
Copy link
Contributor

Many of these feature are now available on all valid LLVM versions.

I've also added a few new ones to the list.

r? @Amanieu

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 3, 2021
@joshtriplett
Copy link
Member

LGTM. (Not r+ing because you specifically requested review from @Amanieu.)

@adamgemmell
Copy link
Contributor Author

@joshtriplett Thank you! Feel free to approve if you'd like - I requested Amanieu just because he's reviewed a lot of similar patches from me in the past.

@Amanieu
Copy link
Member

Amanieu commented Nov 4, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 4, 2021

📌 Commit cdd98bb has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2021
Rollup of 9 pull requests

Successful merges:

 - rust-lang#90507 (Suggest `extern crate alloc` when using undeclared module `alloc`)
 - rust-lang#90530 (Simplify js tester a bit)
 - rust-lang#90533 (Add note about x86 instruction prefixes in asm! to unstable book)
 - rust-lang#90537 (Update aarch64 `target_feature` list for LLVM 12.)
 - rust-lang#90544 (Demote metadata load warning to "info".)
 - rust-lang#90554 (Clean up some `-Z unstable-options` in tests.)
 - rust-lang#90556 (Add more text and examples to `carrying_{add|mul}`)
 - rust-lang#90563 (rustbot allow labels)
 - rust-lang#90571 (Fix missing bottom border for headings in sidebar)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a5802d0 into rust-lang:master Nov 5, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 5, 2021
@adamgemmell adamgemmell deleted the dev/aarch64-target-feature branch November 5, 2021 15:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants