Fix standard library test with read_link #90790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
apiraino
added
the
T-libs
|
@bors r+ rollup |
|
📌 Commit 181716a has been approved by |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Nov 15, 2021
…-Simulacrum Fix standard library test with read_link closes rust-lang#90669 resolve this issue by comparing between Paths instead of strs
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Nov 15, 2021
…-Simulacrum Fix standard library test with read_link closes rust-lang#90669 resolve this issue by comparing between Paths instead of strs
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 15, 2021
…-Simulacrum Fix standard library test with read_link closes rust-lang#90669 resolve this issue by comparing between Paths instead of strs
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 16, 2021
Rollup of 10 pull requests Successful merges: - rust-lang#85766 (Stabilize File::options()) - rust-lang#88601 (Implement `Termination` for `Result<Infallible, E>`) - rust-lang#90058 (Stabilize -Z strip as -C strip) - rust-lang#90790 (Fix standard library test with read_link) - rust-lang#90834 (Android is not GNU) - rust-lang#90835 (Rename WASI's `is_character_device` to `is_char_device`.) - rust-lang#90837 (Move some tests to more reasonable directories - 9) - rust-lang#90848 (Remove bigint_helper_methods for *signed* types) - rust-lang#90892 (fix ICE on Miri/CTFE copy of half a pointer) - rust-lang#90909 (disable portable SIMD tests in Miri) Failed merges: - rust-lang#90128 (Stabilize -Z symbol-mangling-version=v0 as -C symbol-mangling-version=v0) r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #90669
resolve this issue by comparing between Paths instead of strs