-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[beta] backports #90938
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[beta] backports #90938
Conversation
As discussed in rust-lang#88576, raw handle values in Windows can be null, such as in `windows_subsystem` mode, or when consoles are detached from a process. So, don't use `NonNull` to hold them, don't assert that they're not null, and remove `OwnedHandle`'s `repr(transparent)`. Introduce a new `HandleOrNull` type, similar to `HandleOrInvalid`, to cover the FFI use case. (cherry picked from commit 3b97481)
(cherry picked from commit e102c2a)
(cherry picked from commit 5d79870)
Fixes: rust-lang#89658 (cherry picked from commit 1bb399c)
This lint is not yet ready for stable use, primarily due to false positives in edge cases; we want to test it out more before stabilizing. (cherry picked from commit 185fa56)
In rust-lang#89522 we learned that `clone3` is interacting poorly with Gentoo's `sandbox` tool. We only need that for the unstable pidfd extensions, so otherwise avoid that and use a normal `fork`. (cherry picked from commit 85b55ce)
(cherry picked from commit fa2eee7)
Co-authored-by: Josh Triplett <josh@joshtriplett.org> (cherry picked from commit 6edaaa6)
|
@bors r+ rollup=never |
📌 Commit 5818b3581bfc57cab8cafbb1e52c174c571090ca has been approved by |
This comment has been minimized.
This comment has been minimized.
It seems I missed something in #90186, but it looks like a match to me, so perhaps the test is also assuming some other state that's changed since beta. I can't figure out how to run rustdoc-gui locally -- @GuillaumeGomez, can you suggest fixes? |
@cuviper: To run gui tests you first need to run |
Also, the tests were very likely updated in the meantime because new things were added, which is why it's failing. |
⌛ Testing commit 5818b3581bfc57cab8cafbb1e52c174c571090ca with merge 20dcf5fd682b98ea526af7571aee5a3e2ebb04ef... |
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
Looks like its the same problem as in #90561 ? |
This comment has been minimized.
This comment has been minimized.
@bors retry |
⌛ Testing commit 69b4a85 with merge 1564f7a4350638e42211c4236eda0a96c045d95e... |
💥 Test timed out |
This comment has been minimized.
This comment has been minimized.
@bors r=Mark-Simulacrum |
📌 Commit a4a72e7 has been approved by |
☀️ Test successful - checks-actions |
OwnedHandle
withwindows_subsystem
. #88798clone3
when needed for pidfd #89930Box
a parameter to aSelf::func
call #90221Additionally, this bumps the stage 0 compiler from beta to stable 1.56.1.
r? @Mark-Simulacrum