Skip to content

[crater experiment] do the opposite of what zip side-effect documentation currently guarantees #91031

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

the8472
Copy link
Member

@the8472 the8472 commented Nov 19, 2021

Improved crater experiment to elucidate the possibility of completely removing the guarantee that was added in #52279, suggested by @steffahn in #83791 (comment)

That it was already used in linkedlist doesn't bode well. 😢

r? @ghost

@rust-log-analyzer

This comment has been minimized.

@the8472 the8472 force-pushed the experiment-zip-b-before-a branch from 2a7c3af to 14cb270 Compare November 19, 2021 02:20
@the8472
Copy link
Member Author

the8472 commented Nov 20, 2021

Preparing for a crater run.

@bors try

@bors
Copy link
Collaborator

bors commented Nov 20, 2021

⌛ Trying commit 14cb270 with merge 722e1797249a965b6335aebd65d777f917e498f1...

@the8472 the8472 changed the title [Experiment] do the opposite of what zip side-effect documentation currently guarantees [crater experiment] do the opposite of what zip side-effect documentation currently guarantees Nov 20, 2021
@bors
Copy link
Collaborator

bors commented Nov 20, 2021

☀️ Try build successful - checks-actions
Build commit: 722e1797249a965b6335aebd65d777f917e498f1 (722e1797249a965b6335aebd65d777f917e498f1)

@the8472
Copy link
Member Author

the8472 commented Nov 20, 2021

@craterbot run mode=build-and-test

@craterbot
Copy link
Collaborator

👌 Experiment pr-91031 created and queued.
🤖 Automatically detected try build 722e1797249a965b6335aebd65d777f917e498f1
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Nov 20, 2021
@craterbot
Copy link
Collaborator

🚧 Experiment pr-91031 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment pr-91031 has encountered an error: docker is not running
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@the8472
Copy link
Member Author

the8472 commented Nov 23, 2021

@craterbot retry

@craterbot
Copy link
Collaborator

🛠️ Experiment pr-91031 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-91031 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member

@craterbot retry-report

@craterbot
Copy link
Collaborator

🛠️ Generation of the report for pr-91031 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-91031 is completed!
📊 94 regressed and 82 fixed (194633 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Nov 30, 2021
@Mark-Simulacrum
Copy link
Member

Results will still be here if/when desired, but closing the PR itself to get it out of our queue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants