Improve unsafe diagnostic
#91133
Merged
Improve unsafe diagnostic
#91133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
apiraino
added
the
T-compiler
This comment has been minimized.
This comment has been minimized.
terrarier2111
force-pushed
the
unsafe-diagnostic
branch
from
a5ccc7b to
b244b5c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
r? @estebank |
terrarier2111
force-pushed
the
unsafe-diagnostic
branch
5 times, most recently
from
f5a26dc to
8078071
Compare
This comment has been minimized.
This comment has been minimized.
terrarier2111
force-pushed
the
unsafe-diagnostic
branch
3 times, most recently
from
bdd4cae to
1075035
Compare
This comment has been minimized.
This comment has been minimized.
terrarier2111
force-pushed
the
unsafe-diagnostic
branch
2 times, most recently
from
fa2fceb to
f3d2cec
Compare
terrarier2111
force-pushed
the
unsafe-diagnostic
branch
from
ec2ec39 to
3a13a72
Compare
|
@estebank could you take a look at this? |
JohnCSimon
added
S-waiting-on-review
|
It would be amazing for this to get a review. |
|
Sorry for the delay here! @bos r+ |
|
Is there something holding this from being merged ? I'll fix it. |
|
Bors? @bors r+ |
|
📌 Commit 3a13a72 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
|
r? @jackh726 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2022
Rollup of 10 pull requests Successful merges: - rust-lang#91133 (Improve `unsafe` diagnostic) - rust-lang#93222 (Make ErrorReported impossible to construct outside `rustc_errors`) - rust-lang#93745 (Stabilize ADX target feature) - rust-lang#94309 ([generator_interior] Be more precise with scopes of borrowed places) - rust-lang#94698 (Remove redundant code from copy-suggestions) - rust-lang#94731 (Suggest adding `{ .. }` around a const function call with arguments) - rust-lang#94960 (Fix many spelling mistakes) - rust-lang#94982 (Add deprecated_safe feature gate and attribute, cc rust-lang#94978) - rust-lang#94997 (debuginfo: Fix ICE when generating name for type that produces a layout error.) - rust-lang#95000 (Fixed wrong type name in comment) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes: #90880
I didn't use the exact proposed messages though.