Fix bug where submodules wouldn't be updated when running x.py from a subdirectory #91252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… subdirectory Previously, it would concatenate the relative path to the current subdirectory, which looked at the wrong folder. I tested this by checking out `1.56.1`, changing the current directory to `src/`, and running `../x.py build`.
rust-highfive
added
the
S-waiting-on-review
jyn514
added
A-contributor-roadblock
|
@bors r+ |
|
📌 Commit 6e0e220 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 27, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#90611 (Fix another ICE in rustdoc scrape_examples) - rust-lang#91197 (rustdoc: Rename `Type::ResolvedPath` to `Type::Path` and don't re-export it) - rust-lang#91223 (Fix headings indent) - rust-lang#91240 (Saner formatting for UTF8_CHAR_WIDTH table) - rust-lang#91248 (Bump compiler-builtins to 0.1.53) - rust-lang#91252 (Fix bug where submodules wouldn't be updated when running x.py from a subdirectory) - rust-lang#91259 (Remove `--display-doctest-warnings`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it would concatenate the relative path to the current
subdirectory, which looked at the wrong folder.
I tested this by checking out
1.56.1, changing the current directoryto
src/, and running../x.py build.Fixes #90481 (cc @pnkfelix).
r? @Mark-Simulacrum