Rollup of 5 pull requests #91350
Merged
Rollup of 5 pull requests #91350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to the note on [Python's `os.symlink()`](https://docs.python.org/3/library/os.html#os.symlink). Some additional notes in dimo414/bkt#3.
When `-C remark=...` option is specified multiple times, accumulate all values instead of using only the last one.
Add a caveat to std::os::windows::fs::symlink_file This is similar to the note on [Python's `os.symlink()`](https://docs.python.org/3/library/os.html#os.symlink). Some additional notes in dimo414/bkt#3.
…Mark-Simulacrum Add demonstration test for rust-lang#91161 Since cross-crate things are hard to demonstrate in playground, here's a test showing that something currently works that shouldn't. cc rust-lang#91161 that tracks fixing the problem (and updating this test)
Delete an unreachable codepath from format_args implementation
Remove unused root_parent.
…ikic Accumulate all values of `-C remark` option When `-C remark=...` option is specified multiple times, accumulate all values instead of using only the last one. r? `@nikic`
|
@bors r+ rollup=never p=5 |
|
📌 Commit e15e0ba has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (8b95491): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[non_exhaustive]on variant should block cross-crateascasts #91161)-C remarkoption #91349 (Accumulate all values of-C remarkoption)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup