Skip to content

Avoid suggest adding self in visibility spec #91798

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2021
Merged

Avoid suggest adding self in visibility spec #91798

merged 1 commit into from
Dec 15, 2021

Conversation

bugadani
Copy link
Contributor

Fixes #91783

@rust-highfive
Copy link
Contributor

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 11, 2021
estebank
estebank approved these changes Dec 12, 2021
View reviewed changes
@bugadani @estebank
Avoid suggesting self in visibility spec
f3a08fd 
Co-authored-by: Esteban Kuber <estebank@users.noreply.github.com>
@camelid camelid added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 13, 2021
@michaelwoerister
Copy link
Member

Thanks for the PR, @bugadani! Looks good to me.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 14, 2021

📌 Commit f3a08fd has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2021
@matthiaskrgr
Rollup merge of rust-lang#91798 - bugadani:issue-91783, r=michaelwoer…
f8518d5 
…ister

Avoid suggest adding `self` in visibility spec

Fixes rust-lang#91783
This was referenced Dec 14, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 15, 2021
@bors
Auto merge of rust-lang#91933 - matthiaskrgr:rollup-cw9qolb, r=matthi…
d594910 
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#89825 (Make split_inclusive() on an empty slice yield an empty output)
 - rust-lang#91239 (regression test for issue 87490)
 - rust-lang#91597 (Recover on invalid operators `<>` and `<=>`)
 - rust-lang#91774 (Fix typo for MutVisitor)
 - rust-lang#91786 (Return an error when `eval_rvalue_with_identities` fails)
 - rust-lang#91798 (Avoid suggest adding `self` in visibility spec)
 - rust-lang#91856 (Looser check for overflowing_binary_op)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6a94918 into rust-lang:master Dec 15, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 15, 2021
@bugadani bugadani deleted the issue-91783 branch December 15, 2021 15:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@estebank estebank estebank approved these changes

Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.

Wrong position of inserted &self in suggestion of compile error
7 participants
@bugadani @rust-highfive @michaelwoerister @bors @estebank @camelid @rustbot