Skip to content

rustbot: Add autolabeling for T-rustdoc #91817

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 12, 2021
Merged

rustbot: Add autolabeling for T-rustdoc #91817

merged 1 commit into from
Dec 12, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Dec 12, 2021

This commit adds autolabeling for the T-rustdoc label, for PRs that
modify rustdoc's source code, tests, or internal tooling.

This is possible now that rust-lang/triagebot#1321 has landed.

This commit adds autolabeling for the `T-rustdoc` label, for PRs that
modify rustdoc's source code, tests, or internal tooling.

This is possible now that rust-lang/triagebot#1321 has landed.
@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-meta Area: Issues & PRs about the rust-lang/rust repository itself labels Dec 12, 2021
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2021
"src/test/rustdoc-gui",
"src/test/rustdoc-js",
"src/test/rustdoc-js-std",
"src/test/rustdoc-json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice we're currently using a str::starts_with, so just src/test/rustdoc is technically enough, but this seems harmless so likely OK (and we may want to alter that to a Path prefix).

Copy link
Member Author

@camelid camelid Dec 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't realize that! It's probably good to have the paths here not rely on that behavior though :)

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 12, 2021

📌 Commit dce45a9 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 12, 2021
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#91746 (Btree: assert more API compatibility)
 - rust-lang#91748 (rustdoc: Add regression test for Iterator as notable trait on &mut T)
 - rust-lang#91811 (bootstrap: Change unwrap() to expect() for WIX path)
 - rust-lang#91814 (doc: fix typo in comments)
 - rust-lang#91815 (better span for unexpected normalization failure in CTFE engine)
 - rust-lang#91817 (rustbot: Add autolabeling for `T-rustdoc`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 479e189 into master Dec 12, 2021
@bors bors deleted the rustdoc-autolabel branch December 12, 2021 09:57
@rustbot rustbot added this to the 1.59.0 milestone Dec 12, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants