Skip to content

Add test for issue #83474 #91821

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add test for issue #83474 #91821

wants to merge 1 commit into from

Conversation

Badel2
Copy link
Contributor

@Badel2 Badel2 commented Dec 12, 2021

Fix #83474

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2021
@camelid camelid added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 13, 2021
@Mark-Simulacrum
Copy link
Member

Can you expand src/test/ui/lang-items/lang-item-correct-generics.rs or one of the other tests added by #87875, instead of adding a new issue-... test?

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2021
@Badel2
Copy link
Contributor Author

Badel2 commented Dec 13, 2021

Moved the test to src/test/ui/lang-items/lang-item-generic-requirements.rs. I wasn't able to make it show a "mismatched types" error, which I believe is what caused the ICE.

@rust-log-analyzer

This comment has been minimized.

# to view
@JohnCSimon
Copy link
Member

Ping from triage:
@Badel2 can you post your status on this PR?
If it's ready for review send a message containing
@rustbot ready

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 12, 2022
@JohnCSimon
Copy link
Member

@Badel2
Ping from triage: I'm closing this due to inactivity, Please reopen when you are ready to continue with this. Thanks for your contribution.

@rustbot label: +S-inactive

@JohnCSimon JohnCSimon closed this Mar 20, 2022
@rustbot rustbot added the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Mar 20, 2022
@KSBilodeau KSBilodeau mentioned this pull request Apr 6, 2022
Merged
@Dylan-DPC Dylan-DPC removed the S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. label Apr 6, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Apr 7, 2022
@Dylan-DPC
Rollup merge of rust-lang#95714 - KSBilodeau:master, r=Dylan-DPC
2e4964e 
Add test for issue rust-lang#83474

Adds test for rust-lang#83474 - second attempt at PR rust-lang#91821 which was abandoned.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: panicked at 'index out of bounds: the len is 0 but the index is 0', compiler/rustc_middle/src/ty/subst.rs
8 participants
@Badel2 @rust-highfive @Mark-Simulacrum @rust-log-analyzer @JohnCSimon @camelid @rustbot @Dylan-DPC