Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Remove in_band_lifetimes from rustc_symbol_mangling #91901

Merged
merged 1 commit into from
Dec 16, 2021
Merged

Remove in_band_lifetimes from rustc_symbol_mangling #91901

merged 1 commit into from
Dec 16, 2021

Conversation

SylvanB
Copy link
Contributor

@SylvanB SylvanB commented Dec 14, 2021

Helping out with #91867

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 14, 2021
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jackh726 (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2021
@SylvanB SylvanB mentioned this pull request Dec 14, 2021
Closed
21 tasks
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 14, 2021

📌 Commit b682dec has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2021
@matthiaskrgr
Rollup merge of rust-lang#91901 - SylvanB:remove_in_band_lifetimes_ru…
201f391 
…stc_symbol_mangling, r=jackh726

Remove `in_band_lifetimes` from `rustc_symbol_mangling`

Helping out with  rust-lang#91867
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 14, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2021
@matthiaskrgr
Rollup merge of rust-lang#91901 - SylvanB:remove_in_band_lifetimes_ru…
2e3b295 
…stc_symbol_mangling, r=jackh726

Remove `in_band_lifetimes` from `rustc_symbol_mangling`

Helping out with  rust-lang#91867
This was referenced Dec 14, 2021
Closed
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 15, 2021
@matthiaskrgr
Rollup merge of rust-lang#91901 - SylvanB:remove_in_band_lifetimes_ru…
433cde5 
…stc_symbol_mangling, r=jackh726

Remove `in_band_lifetimes` from `rustc_symbol_mangling`

Helping out with  rust-lang#91867
@bors
Copy link
Contributor

bors commented Dec 15, 2021

☔ The latest upstream changes (presumably #91945) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 15, 2021
@SylvanB SylvanB force-pushed the remove_in_band_lifetimes_rustc_symbol_mangling branch from b682dec to 6c4fd61 Compare December 15, 2021 22:02
@SylvanB
Copy link
Contributor Author

SylvanB commented Dec 16, 2021

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 16, 2021
@jackh726
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 16, 2021

📌 Commit 6c4fd61 has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 16, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 16, 2021
@matthiaskrgr
Rollup merge of rust-lang#91901 - SylvanB:remove_in_band_lifetimes_ru…
1a976d0 
…stc_symbol_mangling, r=jackh726

Remove `in_band_lifetimes` from `rustc_symbol_mangling`

Helping out with  rust-lang#91867
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 16, 2021
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 16, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 16, 2021
@bors
Auto merge of rust-lang#91996 - matthiaskrgr:rollup-8pdt8x7, r=matthi…
f840216 
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#91901 (Remove `in_band_lifetimes` from `rustc_symbol_mangling`)
 - rust-lang#91904 (Remove `in_band_lifetimes` from `rustc_trait_selection`)
 - rust-lang#91951 (update stdarch)
 - rust-lang#91958 (Apply rust-logo class only on default logo)
 - rust-lang#91972 (link to pref_align_of tracking issue)
 - rust-lang#91986 (Bump compiler-builtins to 0.1.66)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 02a4e7c into rust-lang:master Dec 16, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 16, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
5 participants
@SylvanB @rust-highfive @jackh726 @bors @rustbot