Skip to content

Add 2 tests #91908

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2022
Merged

Add 2 tests #91908

merged 1 commit into from
Feb 12, 2022

Conversation

matthiaskrgr
Copy link
Member

fixes #91139
fixes #91069

@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 14, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 14, 2021

📌 Commit f58ef22 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2021
@matthiaskrgr
Rollup merge of rust-lang#91908 - matthiaskrgr:ices, r=Mark-Simulacrum
063da9f 
Add 2 tests

fixes rust-lang#91139
fixes rust-lang#91069
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 14, 2021
Closed
jackh726
jackh726 requested changes Dec 14, 2021
View reviewed changes
src/test/ui/generic-associated-types/issue-81069.rs Outdated
@@ -0,0 +1,24 @@
// check-pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this test is named #81069. And doesn't even use GATs, so why is it in this directory?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this was supposed to be 91069, looks like I fatfingered it

@jackh726
Copy link
Member

jackh726 commented Dec 14, 2021 •
edited
Loading

@bors r-

See review. Wrong test?

Edit: right test, wrong name, wrong location

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 14, 2021
@matthiaskrgr
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 14, 2021
@jackh726
Copy link
Member

Still wrong location for 91069 test...not GATs...

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 15, 2021
@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 23, 2022
@matthiaskrgr
Copy link
Member Author

@jackh726 where do you want me to put 91069.rs ?

@jackh726
Copy link
Member

Maybe just associated-types

@matthiaskrgr matthiaskrgr added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2022
@jackh726
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 11, 2022

📌 Commit 9b17e2d has been approved by jackh726

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 12, 2022
@matthiaskrgr
Rollup merge of rust-lang#91908 - matthiaskrgr:ices, r=jackh726
9c58fb5 
Add 2 tests

fixes rust-lang#91139
fixes rust-lang#91069
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 12, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 12, 2022
@matthiaskrgr
Rollup merge of rust-lang#91908 - matthiaskrgr:ices, r=jackh726
22d3784 
Add 2 tests

fixes rust-lang#91139
fixes rust-lang#91069
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 12, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 12, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 12, 2022
@bors
Auto merge of rust-lang#93933 - matthiaskrgr:rollup-1hjae6g, r=matthi…
f8f1751 
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#91908 (Add 2 tests)
 - rust-lang#93595 (fix ICE when parsing lifetime as function argument)
 - rust-lang#93757 (Add some known GAT bugs as tests)
 - rust-lang#93759 (Pretty print ItemKind::Use in rustfmt style)
 - rust-lang#93897 (linkchecker: fix panic on directory symlinks)
 - rust-lang#93898 (tidy: Extend error code check)
 - rust-lang#93928 (Add missing release notes for rust-lang#85200)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 661be4c into rust-lang:master Feb 12, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 12, 2022
@matthiaskrgr matthiaskrgr deleted the ices branch January 25, 2025 09:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jackh726 jackh726 jackh726 requested changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
7 participants
@matthiaskrgr @rust-highfive @Mark-Simulacrum @bors @jackh726 @JohnCSimon @rustbot