Skip to content

resolve: Minor miscellaneous cleanups from #89059 #92161

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2021
Merged

resolve: Minor miscellaneous cleanups from #89059 #92161

merged 1 commit into from
Dec 28, 2021

Conversation

petrochenkov
Copy link
Contributor

@bors rollup=always

@rust-highfive
Copy link
Contributor

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 21, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 21, 2021
@petrochenkov petrochenkov mentioned this pull request Dec 21, 2021
Closed
@rust-log-analyzer

This comment has been minimized.

# to view
@cjgillot
Copy link
Contributor

r? @cjgillot
@bors r+

@bors
Copy link
Collaborator

bors commented Dec 26, 2021

📌 Commit 1324100 has been approved by cjgillot

@rust-highfive rust-highfive assigned cjgillot and unassigned nagisa Dec 26, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 26, 2021
@bors
Copy link
Collaborator

bors commented Dec 27, 2021

⌛ Testing commit 1324100 with merge 75708f7f10f343f68edf35d4fa3d7347f64c4672...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-cargo failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
fatal: Could not parse object '91493fe47175076f330ce5fc518f0196c0476f56'.
error: RPC failed; curl 56 OpenSSL SSL_read: Connection was reset, errno 10054
error: 15 bytes of body are still expected
fatal: expected flush after ref listing
thread 'main' panicked at 'assertion failed: status.success()', src\tools\cargotest\main.rs:125:13


command did not execute successfully: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0-tools-bin\\cargotest.exe" "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage2-tools-bin\\cargo.exe" "D:\\a\\rust\\rust\\build\\ct"
expected success, got: exit code: 101

@bors
Copy link
Collaborator

bors commented Dec 27, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2021
@petrochenkov
Copy link
Contributor Author

@bors r=cjgillot rollup

@bors
Copy link
Collaborator

bors commented Dec 27, 2021

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: Add Attribute::meta_kind #92294

@bors
Copy link
Collaborator

bors commented Dec 27, 2021

📌 Commit 1324100 has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2021
@bors
Copy link
Collaborator

bors commented Dec 27, 2021

⌛ Testing commit 1324100 with merge ef6f773c97230531e0178453528bee9f05ce5f83...

@bors
Copy link
Collaborator

bors commented Dec 27, 2021

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 27, 2021
@lnicola
Copy link
Member

lnicola commented Dec 27, 2021

@bors retry

GitHub had a bad day.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@matthiaskrgr matthiaskrgr mentioned this pull request Dec 27, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2021
@bors
Auto merge of rust-lang#92329 - matthiaskrgr:rollup-l3b4fl1, r=matthi…
4ee34f3 
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#90586 (Relax priv-in-pub lint on generic bounds and where clauses of trait impls.)
 - rust-lang#92112 (Fix the error of checking `base_expr` twice in type_changing_struct_update)
 - rust-lang#92147 (rustc_builtin_macros: make asm mod public for rustfmt)
 - rust-lang#92161 (resolve: Minor miscellaneous cleanups from rust-lang#89059)
 - rust-lang#92264 (Remove `maybe_uninit_extra` feature from Vec docs)
 - rust-lang#92303 (Add test cases for issue rust-lang#26186)
 - rust-lang#92307 (Fix minor typos)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a11414d into rust-lang:master Dec 28, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 28, 2021
@petrochenkov petrochenkov deleted the misclean branch February 22, 2025 18:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.59.0
Development

Successfully merging this pull request may close these issues.
8 participants
@petrochenkov @rust-highfive @rust-log-analyzer @cjgillot @bors @lnicola @nagisa @rustbot