Skip to content

Add tests for three old ICEs #92312

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 29, 2022
Merged

Add tests for three old ICEs #92312

merged 3 commits into from
Jan 29, 2022

Conversation

BGR360
Copy link
Contributor

@BGR360 BGR360 commented Dec 27, 2021

Closes #84044
Closes #91594
Closes #89066

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 27, 2021
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 27, 2021
BGR360
BGR360 commented Dec 27, 2021
View reviewed changes
@BGR360 BGR360 force-pushed the needs-test branch 2 times, most recently from b64b773 to db27403 Compare December 28, 2021 20:24
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 5, 2022

📌 Commit db27403 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2022
@matthiaskrgr
Rollup merge of rust-lang#92312 - BGR360:needs-test, r=Mark-Simulacrum
2e0b081 
Add tests for three old ICEs

Closes rust-lang#84044
Closes rust-lang#91594
Closes rust-lang#89066
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 5, 2022
Closed
@matthiaskrgr
Copy link
Member

@bors r- failed in a rollup
#92571 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 5, 2022
@camelid
Copy link
Member

camelid commented Jan 25, 2022

triage: @BGR360 could you please fix the test failure using ./x.py test --bless?

@camelid camelid added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 25, 2022
BGR360
BGR360 commented Jan 25, 2022
View reviewed changes
src/test/ui/save-analysis/issue-89066.rs Outdated
@@ -1,7 +1,7 @@
// compile-flags: -Zsave-analysis

// Check that this does not ICE.
// Stolen from src/test/ui/inference/infer-arg-test.rs
// Stolen from src/test/ui/const-generics/generic_arg_infer/infer-arg-test.stderr
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=iffy

Squashed the last commit in rather than having it be separate.

@bors
Copy link
Collaborator

bors commented Jan 28, 2022

📌 Commit 3f849a8 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2022
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-12 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 

running 165 tests
...................................i...........................

command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/mir-opt" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/mir-opt" "--stage-id" "stage2-i686-unknown-linux-gnu" "--suite" "mir-opt" "--mode" "mir-opt" "--target" "i686-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-12/bin/FileCheck" "--nodejs" "/usr/bin/node" "--linker" "cc" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0  -Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python3" "--lldb-python" "/usr/bin/python3" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "12.0.0" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo cfguard codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver dwarflinker engine executionengine extensions filecheck frontendopenacc frontendopenmp fuzzmutate globalisel hellonew hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interfacestub interpreter ipo irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit orcshared orctargetprocess passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--channel" "nightly" "--color" "always"
expected success, got: signal: 11 (core dumped)

Build completed unsuccessfully in 0:01:33

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 29, 2022
@matthiaskrgr
Rollup merge of rust-lang#92312 - BGR360:needs-test, r=Mark-Simulacrum
ee9307d 
Add tests for three old ICEs

Closes rust-lang#84044
Closes rust-lang#91594
Closes rust-lang#89066
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 29, 2022
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 29, 2022
@matthiaskrgr
Rollup merge of rust-lang#92312 - BGR360:needs-test, r=Mark-Simulacrum
2b684a3 
Add tests for three old ICEs

Closes rust-lang#84044
Closes rust-lang#91594
Closes rust-lang#89066
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 29, 2022
Closed
@bors
Copy link
Collaborator

bors commented Jan 29, 2022

⌛ Testing commit 3f849a8 with merge d08e816...

@bors
Copy link
Collaborator

bors commented Jan 29, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing d08e816 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 29, 2022
@bors bors merged commit d08e816 into rust-lang:master Jan 29, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 29, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d08e816): comparison url.

Summary: This benchmark run did not return any relevant results.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
10 participants
@BGR360 @rust-highfive @Mark-Simulacrum @bors @matthiaskrgr @camelid @rust-log-analyzer @rust-timer @compiler-errors @rustbot