Enforce formatting for rustc_codegen_cranelift #92438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Some changes occured to rustc_codegen_cranelift cc @bjorn3 |
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
petrochenkov
added
S-blocked
|
No longer blocked, just needs rebase now. @rustbot author |
rustbot
added
the
S-waiting-on-author
camelid
removed
the
S-blocked
bjorn3
force-pushed
the
less_cg_clif_exceptions
branch
from
0a17442 to
bffe880
Compare
|
Rebased |
bjorn3
added
S-waiting-on-review
|
@bors r+ Seems OK to me, though note that the rustfmt used in rust-lang/rust CI is from a pinned nightly, bumped alongside the bootstrap compiler. |
|
📌 Commit bffe880 has been approved by |
bors
added
S-waiting-on-bors
|
Is there an issue filed for the breakage rustfmt causes with |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 2, 2022
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#84083 (Clarify the guarantees that ThreadId does and doesn't make.) - rust-lang#91593 (Remove unnecessary bounds for some Hash{Map,Set} methods) - rust-lang#92297 (Reduce compile time of rustbuild) - rust-lang#92332 (Add test for where clause order) - rust-lang#92438 (Enforce formatting for rustc_codegen_cranelift) - rust-lang#92463 (Remove pronunciation guide from Vec<T>) - rust-lang#92468 (Emit an error for `--cfg=)`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
The breakage to y.rs isn't rustfmt's fault. It starts with: #!/usr/bin/env bash
#![allow()] /*This line is ignored by bash
# This block is ignored by rustcRustfmt puts the comment on a newline, but this causes it to be interpreted as command by bash rather than as comment. |
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#84083 (Clarify the guarantees that ThreadId does and doesn't make.) - rust-lang#91593 (Remove unnecessary bounds for some Hash{Map,Set} methods) - rust-lang#92297 (Reduce compile time of rustbuild) - rust-lang#92332 (Add test for where clause order) - rust-lang#92438 (Enforce formatting for rustc_codegen_cranelift) - rust-lang#92463 (Remove pronunciation guide from Vec<T>) - rust-lang#92468 (Emit an error for `--cfg=)`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.