Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement RFC 3151: Scoped threads. #92555

Merged
merged 18 commits into from
Jan 24, 2022
Merged

Implement RFC 3151: Scoped threads. #92555

merged 18 commits into from
Jan 24, 2022

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Jan 4, 2022 •
edited
Loading

This implements rust-lang/rfcs#3151

Tracking issue: #93203

r? @Amanieu

m-ou-se added 5 commits January 4, 2022 14:08
@m-ou-se
Simpilfy thread::JoinInner.
a45b3ac
@m-ou-se
Implement RFC 3151: Scoped threads.
0e24ad5
@m-ou-se
Add ScopedJoinHandle::is_running().
cc699e1
@m-ou-se
Add documentation for scoped threads.
da33da1
@m-ou-se
Simplify panicking mechanism of thread::scope.
f521779 
It now panic!()s on its own, rather than resume_unwind'ing the panic
payload from the thread. Using resume_unwind skips the panic_handler,
meaning that the main thread would never have a panic handler run, which
can get confusing.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2022
@m-ou-se m-ou-se mentioned this pull request Jan 4, 2022
Merged
@m-ou-se m-ou-se added T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows labels Jan 4, 2022
@rust-log-analyzer

This comment has been minimized.

# to view
@m-ou-se @MattiasBuelens
Fix typo in is_running() docs.
c429ade 
Co-authored-by: Mattias Buelens <649348+MattiasBuelens@users.noreply.github.com>
@m-ou-se @deltragon
Fix typo in Scope::spawn docs.
5b5746f 
Co-authored-by: deltragon <m@dafert.at>
danielhenrymantilla
danielhenrymantilla reviewed Jan 4, 2022
View reviewed changes
Copy link
Contributor

@danielhenrymantilla danielhenrymantilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty slick!

Amanieu
Amanieu reviewed Jan 5, 2022
View reviewed changes
@m-ou-se @Amanieu
Mention *scoped* thread in panic message.
4cb7370 
Co-authored-by: Amanieu d'Antras <amanieu@gmail.com>
@m-ou-se m-ou-se mentioned this pull request Jan 22, 2022
Closed
10 tasks
@m-ou-se m-ou-se added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 22, 2022
@m-ou-se
Copy link
Member Author

m-ou-se commented Jan 22, 2022

@Amanieu I've added the tracking issue number, so this is now ready for review/merging.

@Amanieu
Copy link
Member

Amanieu commented Jan 23, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 23, 2022

📌 Commit 465c405 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 23, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 23, 2022
@bors
Auto merge of rust-lang#93245 - matthiaskrgr:rollup-djsi6jr, r=matthi…
42313dd 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#91526 (rustc_lint: Some early linting refactorings)
 - rust-lang#92555 (Implement RFC 3151: Scoped threads.)
 - rust-lang#93213 (Fix `let_chains` and `if_let_guard` feature flags)
 - rust-lang#93219 (Add preliminary support for inline assembly for msp430.)
 - rust-lang#93226 (Normalize field access types during borrowck)
 - rust-lang#93227 (Liberate late bound regions when collecting GAT substs in wfcheck)
 - rust-lang#93229 (Remove DiagnosticBuilder.quiet)
 - rust-lang#93234 (rustc_mir_itertools: Avoid needless `collect` with itertools)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bb260e8 into rust-lang:master Jan 24, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 24, 2022
@m-ou-se m-ou-se deleted the scoped-threads branch January 24, 2022 06:42
@gregbuchholz gregbuchholz mentioned this pull request Feb 5, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

@frewsxcv frewsxcv frewsxcv left review comments

@MattiasBuelens MattiasBuelens MattiasBuelens left review comments

@zesterer zesterer zesterer left review comments

@programmerjake programmerjake programmerjake left review comments

@chorman0773 chorman0773 chorman0773 left review comments

@danielhenrymantilla danielhenrymantilla danielhenrymantilla left review comments

@deltragon deltragon deltragon left review comments

Assignees

@Amanieu Amanieu

Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.