rustdoc: Introduce a resolver cache for sharing data between early doc link resolution and later passes #92608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
T-compiler
rust-highfive
added
the
S-waiting-on-review
petrochenkov
commented
Jan 6, 2022
|
I'm on vacation for a while. r? rust-lang/rustdoc |
|
cc @CraftSpider |
|
I'll try to review this tonight once I'm out of work |
CraftSpider
reviewed
Jan 7, 2022
This comment has been minimized.
This comment has been minimized.
petrochenkov
added
S-waiting-on-author
…c link resolution and later passes
petrochenkov
force-pushed
the
doctrscope3
branch
from
68c2f9e to
5acd1f9
Compare
petrochenkov
added
S-waiting-on-review
|
Thanks for the changes and comments, looks good |
|
📌 Commit 5acd1f9 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 9, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#92055 (Add release notes for 1.58) - rust-lang#92490 (Move crate drop-down to search results page) - rust-lang#92510 (Don't resolve blocks in foreign functions) - rust-lang#92573 (expand: Refactor InvocationCollector visitor for better code reuse) - rust-lang#92608 (rustdoc: Introduce a resolver cache for sharing data between early doc link resolution and later passes) - rust-lang#92657 (Implemented const casts of raw pointers) - rust-lang#92671 (Make `Atomic*::from_mut` return `&mut Atomic*`) - rust-lang#92673 (Remove useless collapse toggle on "all items" page) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
dario23
added a commit
to dario23/rust-semverver
that referenced
this pull request
May 4, 2022
dario23
added a commit
to dario23/rust-semverver
that referenced
this pull request
May 6, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring parts of #88679, shouldn't cause any slowdowns.
r? @jyn514