Skip to content

Remove horizontal lines at top of page #92797

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2022
Merged

Remove horizontal lines at top of page #92797

merged 1 commit into from
Jan 19, 2022

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Jan 11, 2022

They are not needed to separate the search bar and the title, which are visually distinct on their own.

Part of #59840

Demo: https://rustdoc.crud.net/jsha/fewer-lines/std/string/struct.String.html

r? @GuillaumeGomez

@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jan 11, 2022
@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 11, 2022
@rust-log-analyzer

This comment has been minimized.

# to view
@camelid
Copy link
Member

camelid commented Jan 12, 2022

Ah, what a nice improvement!

@rust-log-analyzer

This comment has been minimized.

# to view
@jsha
Copy link
Contributor Author

jsha commented Jan 12, 2022

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2022
@camelid
Copy link
Member

camelid commented Jan 12, 2022

@jsha the test failure was not from bors, it was from PR CI. You can re-run that by clicking "re-run all jobs" on this page: https://github.com/rust-lang/rust/runs/4793628088?check_suite_focus=true. But it might not be worth it.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 12, 2022
@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2022
@jsha
Copy link
Contributor Author

jsha commented Jan 15, 2022

Bump on this one when you get a chance @GuillaumeGomez.

@GuillaumeGomez
Copy link
Member

@jsha I don't think it's coming from your PR but just in case, can you rebase it on top of master please? Then r=me.

@rust-log-analyzer

This comment has been minimized.

# to view
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jan 17, 2022

📌 Commit ddc328c159390d3562326993683349f57d451c69 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 17, 2022
@jsha
Copy link
Contributor Author

jsha commented Jan 17, 2022

Thanks for the review! Temporarily bumping this out of the queue because it has a change to toggle-docs-mobile that will conflict with the changes in #92629. Letting that one merge first.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 17, 2022
@bors
Copy link
Collaborator

bors commented Jan 18, 2022

☔ The latest upstream changes (presumably #93021) made this pull request unmergeable. Please resolve the merge conflicts.

@camelid
Copy link
Member

camelid commented Jan 18, 2022 •
edited
Loading

@jsha should this be re-approved now or does it need a new review?

@jsha
Copy link
Contributor Author

jsha commented Jan 19, 2022

It shouldn't get reapproved quite yet. There's another PR in the queue (#92861) that also touches toggle-docs-mobile and will generate a conflict. Once that's landed I'll rebase this and reapprove it.

@bors
Copy link
Collaborator

bors commented Jan 19, 2022

☔ The latest upstream changes (presumably #93048) made this pull request unmergeable. Please resolve the merge conflicts.

@jsha
Remove horizontal lines at top of page
fa9a843 
They are not needed to separate the search bar and the title, which are
visually distinct on their own.
@jsha
Copy link
Contributor Author

jsha commented Jan 19, 2022

@bors r=GuillaumeGomez rollup

I decided to make another revision on #92861, so it will need another review; this one can go ahead of it.

@bors
Copy link
Collaborator

bors commented Jan 19, 2022

📌 Commit fa9a843 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 19, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 19, 2022
@bors
Auto merge of rust-lang#93069 - matthiaskrgr:rollup-gx1vkp7, r=matthi…
5e57faa 
…askrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#88642 (Formally implement let chains)
 - rust-lang#89621 (doc: guarantee call order for sort_by_cached_key)
 - rust-lang#91278 (Use iterator instead of recursion in `codegen_place`)
 - rust-lang#92124 (Little improves in CString `new` when creating from slice)
 - rust-lang#92783 (Annotate dead code lint with notes about ignored derived impls)
 - rust-lang#92797 (Remove horizontal lines at top of page)
 - rust-lang#92920 (Move expr- and item-related pretty printing functions to modules)
 - rust-lang#93041 (Remove some unused ordering derivations based on `DefId`)
 - rust-lang#93051 (Add Option::is_some_with and Result::is_{ok,err}_with)
 - rust-lang#93062 (Update books)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@jsha jsha mentioned this pull request Jan 19, 2022
Open
8 tasks
@bors bors merged commit 7f2dbcb into rust-lang:master Jan 19, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 19, 2022
@jsha jsha mentioned this pull request Jan 21, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2022
@matthiaskrgr
Rollup merge of rust-lang#93172 - jsha:re-remove-line, r=camelid
b0a7732 
rustdoc: remove dashed underline under main heading

This was removed in rust-lang#92797 but accidentally re-introduced by a bad merge in rust-lang#92861.

r? `@camelid`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2022
@matthiaskrgr
Rollup merge of rust-lang#93172 - jsha:re-remove-line, r=camelid
9a93de8 
rustdoc: remove dashed underline under main heading

This was removed in rust-lang#92797 but accidentally re-introduced by a bad merge in rust-lang#92861.

r? ``@camelid``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 22, 2022
@matthiaskrgr
Rollup merge of rust-lang#93172 - jsha:re-remove-line, r=camelid
19e414a 
rustdoc: remove dashed underline under main heading

This was removed in rust-lang#92797 but accidentally re-introduced by a bad merge in rust-lang#92861.

r? ```@camelid```
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jsha @rust-highfive @rust-log-analyzer @camelid @GuillaumeGomez @bors @rustbot