rustdoc: Use intersperse in a visit_path function
#92947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
|
r? @jsha (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
vacuus
changed the title
collect in <EmitIgnoredResolutionErrors as Visitor>::visit_pathcollect in <[long type name] as Visitor>::visit_path
camelid
reviewed
Jan 15, 2022
camelid
changed the title
collect in <[long type name] as Visitor>::visit_pathintersperse in a visit_path function
camelid
reviewed
Jan 15, 2022
src/librustdoc/core.rs
Outdated
| .collect::<Vec<_>>() | ||
| .join("::") | ||
| .map(|segment| segment.ident.as_str()) | ||
| .intersperse_with(|| "::") |
There was a problem hiding this comment.
Can you do this? If not, can you post the error?
Suggested change
| .intersperse_with(|| "::") | |
| .intersperse("::") |
There was a problem hiding this comment.
Apparently it does work. I must've misjudged the trait impls somewhere.
camelid
added
S-waiting-on-author
|
@bors r+ |
|
📌 Commit 47de5b4 has been approved by |
bors
added
S-waiting-on-bors
|
This is an error path AFAICT, so @bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 18, 2022
…askrgr Rollup of 14 pull requests Successful merges: - rust-lang#92629 (Pick themes on settings page, not every page) - rust-lang#92640 (Fix ICEs related to `Deref<Target=[T; N]>` on newtypes) - rust-lang#92701 (Add some more attribute validation) - rust-lang#92803 (Hide mobile sidebar on some clicks) - rust-lang#92830 (Rustdoc style cleanups) - rust-lang#92866 ("Does exists" typos fix) - rust-lang#92870 (add `rustc_diagnostic_item` attribute to `AtomicBool` type) - rust-lang#92914 (htmldocck: Add support for `/text()` in ``@snapshot`)` - rust-lang#92923 (Abstract the pretty printer's ringbuffer to be infinitely sized) - rust-lang#92946 (Exclude llvm-libunwind from the self-contained set on s390x-musl targets) - rust-lang#92947 (rustdoc: Use `intersperse` in a `visit_path` function) - rust-lang#92997 (Add `~const` bound test for negative impls) - rust-lang#93004 (update codegen test for LLVM 14) - rust-lang#93016 (Stabilize vec_spare_capacity) Failed merges: - rust-lang#92924 (Delete pretty printer tracing) r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(
Is there a better way to word the title?Eh, this works, I guess.)I'm surprised that the compiler didn't complain when I left out the
.to_string(), but hey, if it works then it works.