Don't suggest inaccessible fields #93039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
fmease
reviewed
Jan 18, 2022
This comment has been minimized.
This comment has been minimized.
terrarier2111
force-pushed
the
fix-field-help
branch
2 times, most recently
from
c9b8125 to
0c02f71
Compare
nagisa
reviewed
Jan 22, 2022
|
I think the commit message/PR description could be improved to be more descriptive of change being made here, before this is merged. Once that's done and the nit is fixed (or there's actually a good reason to do the things the way done right now) r=me. |
terrarier2111
force-pushed
the
fix-field-help
branch
from
bf23acb to
5b32e87
Compare
terrarier2111
force-pushed
the
fix-field-help
branch
from
5b32e87 to
b7f8a8b
Compare
Done. |
This comment has been minimized.
This comment has been minimized.
terrarier2111
force-pushed
the
fix-field-help
branch
from
8f7b00b to
ecd06e1
Compare
|
@bors r+ |
|
📌 Commit ecd06e1 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 30, 2022
Don't suggest inaccessible fields Fixes: rust-lang#92999
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 31, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#90277 (Improve terminology around "after typeck") - rust-lang#92918 (Allow eliding GATs in expression position) - rust-lang#93039 (Don't suggest inaccessible fields) - rust-lang#93155 (Switch pretty printer to block-based indentation) - rust-lang#93214 (Respect doc(hidden) when suggesting available fields) - rust-lang#93347 (Make `char::DecodeUtf16::size_hist` more precise) - rust-lang#93392 (Clarify documentation on char::MAX) - rust-lang#93444 (Fix some CSS warnings and errors from VS Code) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #92999