Skip to content

Fix CVE-2022-21658 #93112

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 20, 2022
Merged

Fix CVE-2022-21658 #93112

merged 5 commits into from
Jan 20, 2022

Conversation

pietroalbini
Copy link
Member

@pietroalbini
Copy link
Member Author

@bors r+ p=250

@bors
Copy link
Collaborator

bors commented Jan 20, 2022

📌 Commit 32080ad has been approved by pietroalbini

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 20, 2022
@pietroalbini
Copy link
Member Author

@bors r+ p=250

@bors
Copy link
Collaborator

bors commented Jan 20, 2022

📌 Commit 0a6c9ad has been approved by pietroalbini

@bors
Copy link
Collaborator

bors commented Jan 20, 2022

🌲 The tree is currently closed for pull requests below priority 600. This pull request will be tested once the tree is reopened.

@matthiaskrgr matthiaskrgr mentioned this pull request Jan 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 20, 2022
@bors
Auto merge of rust-lang#93119 - matthiaskrgr:rollup-ku3cn5j, r=matthi…
777bb86 
…askrgr

Rollup of 13 pull requests

Successful merges:

 - rust-lang#89747 (Add MaybeUninit::(slice_)as_bytes(_mut))
 - rust-lang#89764 (Fix variant index / discriminant confusion in uninhabited enum branching)
 - rust-lang#91606 (Stabilize `-Z print-link-args` as `--print link-args`)
 - rust-lang#91694 (rustdoc: decouple stability and const-stability)
 - rust-lang#92183 (Point at correct argument when async fn output type lifetime disagrees with signature)
 - rust-lang#92582 (improve `_` constants in item signature handling)
 - rust-lang#92680 (intra-doc: Use the impl's assoc item where possible)
 - rust-lang#92704 (Change lint message to be stronger for &T -> &mut T transmute)
 - rust-lang#92861 (Rustdoc mobile: put out-of-band info on its own line)
 - rust-lang#92992 (Help optimize out backtraces when disabled)
 - rust-lang#93038 (Fix star handling in block doc comments)
 - rust-lang#93108 (:arrow_up: rust-analyzer)
 - rust-lang#93112 (Fix CVE-2022-21658)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@the8472 the8472 mentioned this pull request Jan 20, 2022
Open
sunfishcode added a commit to bytecodealliance/cap-std that referenced this pull request Jan 20, 2022
@sunfishcode
Fix a race condition in remove_dir_all.
bef2e70 
Port the fix from rust-lang/rust#93112 to cap-std.
@sunfishcode sunfishcode mentioned this pull request Jan 20, 2022
Merged
@bors bors merged commit dbc9749 into rust-lang:master Jan 20, 2022
@rustbot rustbot added this to the 1.60.0 milestone Jan 20, 2022
sunfishcode added a commit to bytecodealliance/cap-std that referenced this pull request Jan 21, 2022
@sunfishcode
Fix a race condition in remove_dir_all. (#222)
4191da8 
Port the fix from rust-lang/rust#93112 to cap-std.
@jclulow jclulow mentioned this pull request Feb 24, 2022
Closed
seritools added a commit to rust9x/rust that referenced this pull request Dec 29, 2023
@seritools
Fall back to old impl for remove_dir_all
698f731 
The recursive directory removal implementation falls back to the old one
if the necessary APIs are not available (`NtCreateFile`,
`GetFileInformationByHandleEx`, `SetFileInformationByHandle`). The APIs
are available on Vista/Server 2008.

See notes on `fileextd.lib` above to extend the support to Windows
XP/Server 2003. **This might cause security issues**, see
rust-lang#93112
mbilker pushed a commit to mbilker/rust that referenced this pull request Jul 17, 2024
@seritools @mbilker
Fall back to old impl for remove_dir_all
7c12644 
The recursive directory removal implementation falls back to the old one
if the necessary APIs are not available (`NtCreateFile`,
`GetFileInformationByHandleEx`, `SetFileInformationByHandle`). The APIs
are available on Vista/Server 2008.

See notes on `fileextd.lib` above to extend the support to Windows
XP/Server 2003. **This might cause security issues**, see
rust-lang#93112
snev68 added a commit to snev68/cap-std that referenced this pull request Aug 5, 2024
@snev68
Fix a race condition in remove_dir_all. (#222)
002d17a 
Port the fix from rust-lang/rust#93112 to cap-std.
@jieyouxu jieyouxu mentioned this pull request Aug 20, 2024
Merged
seritools added a commit to rust9x/rust that referenced this pull request Dec 1, 2024
@seritools
Fall back to old impl for remove_dir_all
0414fca 
The recursive directory removal implementation falls back to the old one
if the necessary APIs are not available (`NtCreateFile`,
`GetFileInformationByHandleEx`, `SetFileInformationByHandle`). The APIs
are available on Vista/Server 2008.

See notes on `fileextd.lib` above to extend the support to Windows
XP/Server 2003. **This might cause security issues**, see
rust-lang#93112
seritools added a commit to rust9x/rust that referenced this pull request Dec 1, 2024
@seritools
Fall back to old impl for remove_dir_all
9ed04ab 
The recursive directory removal implementation falls back to the old one
if the necessary APIs are not available (`NtCreateFile`,
`GetFileInformationByHandleEx`, `SetFileInformationByHandle`). The APIs
are available on Vista/Server 2008.

See notes on `fileextd.lib` above to extend the support to Windows
XP/Server 2003. **This might cause security issues**, see
rust-lang#93112
seritools added a commit to rust9x/rust that referenced this pull request Dec 3, 2024
@seritools
Fall back to old impl for remove_dir_all
2d93005 
The recursive directory removal implementation falls back to the old one
if the necessary APIs are not available (`NtCreateFile`,
`GetFileInformationByHandleEx`, `SetFileInformationByHandle`). The APIs
are available on Vista/Server 2008.

See notes on `fileextd.lib` above to extend the support to Windows
XP/Server 2003. **This might cause security issues**, see
rust-lang#93112
seritools added a commit to rust9x/rust that referenced this pull request Feb 21, 2025
@seritools
Fall back to old impl for remove_dir_all
a3bec9b 
The recursive directory removal implementation falls back to the old one
if the necessary APIs are not available (`NtCreateFile`,
`GetFileInformationByHandleEx`, `SetFileInformationByHandle`). The APIs
are available on Vista/Server 2008.

See notes on `fileextd.lib` above to extend the support to Windows
XP/Server 2003. **This might cause security issues**, see
rust-lang#93112
seritools added a commit to rust9x/rust that referenced this pull request Apr 2, 2025
@seritools
Fall back to old impl for remove_dir_all
fc39ff1 
The recursive directory removal implementation falls back to the old one
if the necessary APIs are not available (`NtCreateFile`,
`GetFileInformationByHandleEx`, `SetFileInformationByHandle`). The APIs
are available on Vista/Server 2008.

See notes on `fileextd.lib` above to extend the support to Windows
XP/Server 2003. **This might cause security issues**, see
rust-lang#93112
@pietroalbini pietroalbini deleted the pa-cve-2022-21658-nightly branch May 9, 2025 15:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.60.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pietroalbini @bors @rustbot @ChrisDenton @hkratz @alexcrichton