Some unwinding related cg_ssa cleanups #93261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arf and msvc instructions
Given that these instructions are diverging, not every codegen backend may be able to produce a return value for them.
bjorn3
added
C-cleanup
|
Some changes occured to rustc_codegen_gcc cc @antoyo |
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
bjorn3
commented
Jan 24, 2022
| } | ||
| } | ||
|
|
||
| fn set_cleanup(&mut self, landing_pad: &'ll Value) { | ||
| fn cleanup_landing_pad(&mut self, ty: &'ll Type, pers_fn: &'ll Value) -> &'ll Value { | ||
| let landing_pad = self.landing_pad(ty, pers_fn, 1 /* FIXME should this be 0? */); |
There was a problem hiding this comment.
cg_ssa passed 1 here, but I think it should be 0 as it doesn't call .add_clause() on the landing pad.
This comment has been minimized.
This comment has been minimized.
Some codegen backends may require all handlers to be immediately known
bjorn3
force-pushed
the
cg_ssa_refactor6
branch
from
0544c8b to
f6ce771
Compare
|
This is a pure refactor with no behavioural change. |
|
📌 Commit f6ce771 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 28, 2022
Some unwinding related cg_ssa cleanups These should make it a bit easier for alternative codegen backends to implement unwinding.
This was referenced Jan 28, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#92611 (Add links to the reference and rust by example for asm! docs and lints) - rust-lang#93158 (wasi: implement `sock_accept` and enable networking) - rust-lang#93239 (Add os::unix::net::SocketAddr::from_path) - rust-lang#93261 (Some unwinding related cg_ssa cleanups) - rust-lang#93295 (Avoid double panics when using `TempDir` in tests) - rust-lang#93353 (Unimpl {Add,Sub,Mul,Div,Rem,BitXor,BitOr,BitAnd}<$t> for Saturating<$t>) - rust-lang#93356 (Edit docs introduction for `std::cmp::PartialOrd`) - rust-lang#93375 (fix typo `documenation`) - rust-lang#93399 (rustbuild: Fix compiletest warning when building outside of root.) - rust-lang#93404 (Fix a typo from rust-lang#92899) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should make it a bit easier for alternative codegen backends to implement unwinding.