Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Remove extra newlines from junit output #93600

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

last-partizan
Copy link
Contributor

This PR fixes extra newline in junit output #93454

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dtolnay (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 2, 2022
@dtolnay
Copy link
Member

dtolnay commented Feb 2, 2022

r? @yaahc

@rust-highfive rust-highfive assigned yaahc and unassigned dtolnay Feb 2, 2022
@dtolnay
Copy link
Member

dtolnay commented Feb 2, 2022

(Since this is partially reverting #89235)

@yaahc
Copy link
Member

yaahc commented Feb 3, 2022

Looks great, thank you @last-partizan!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 3, 2022

📌 Commit 088474a has been approved by yaahc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 3, 2022
…r=yaahc

fix: Remove extra newlines from junit output

This PR fixes extra newline in junit output rust-lang#93454
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#92310 (rustdoc: Fix ICE report)
 - rust-lang#92802 (Deduplicate lines in long const-eval stack trace)
 - rust-lang#93515 (Factor convenience functions out of main printer implementation)
 - rust-lang#93566 (Make rustc use `RUST_BACKTRACE=full` by default)
 - rust-lang#93589 (Use Option::then in two places)
 - rust-lang#93600 (fix: Remove extra newlines from junit output)
 - rust-lang#93606 (Correct incorrect description of preorder traversals)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 95efb2b into rust-lang:master Feb 3, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 3, 2022
@last-partizan last-partizan deleted the fix-junit-formatter branch February 4, 2022 11:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants