Add regression tests for issue 80309 #93649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Tidy is unhappy, maybe put it in a new folder like r? @oli-obk |
WaffleLapkin
force-pushed
the
regression_test_80309
branch
from
354cd68 to
8e99d92
Compare
|
Uh oh. Looks like this is still happening... maybe CI has a different llvm? brb reading some diffs |
|
I guess CI being @rust-lang/wg-llvm should we wait until CI is bumped or can we ignore the tests on an old llvm somehow? |
|
|
oli-obk
added
S-waiting-on-author
|
@bors r+ rollup |
|
📌 Commit a3b1bc1 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 5, 2022
… r=oli-obk Add regression tests for issue 80309 Closes rust-lang#80309 😝 I'm not sure where to put the tests, is `ui/issues` the right place for this kind of tests?
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 6, 2022
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#91939 (Clarify error on casting larger integers to char) - rust-lang#92300 (mips64-openwrt-linux-musl: Add Tier 3 target) - rust-lang#92383 (Add new target armv7-unknown-linux-uclibceabi (softfloat)) - rust-lang#92651 (Remove "up here" arrow on item-infos) - rust-lang#93556 (Change struct expr pretty printing to match rustfmt style) - rust-lang#93649 (Add regression tests for issue 80309) - rust-lang#93657 (Update CPU idle tracking for apple hosts) - rust-lang#93659 (Refactor conditional) - rust-lang#93669 (Resolve lifetimes for const generic defaults) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #80309 😝
I'm not sure where to put the tests, is
ui/issuesthe right place for this kind of tests?