-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rollup of 2 pull requests #93695
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rollup of 2 pull requests #93695
Conversation
This was supposed to be the case previously, but a missed method call meant that trait impls were not checked.
…oli-obk Require const stability attribute on all stable functions that are `const` This PR requires all stable functions (of all kinds) that are `const fn` to have a `#[rustc_const_stable]` or `#[rustc_const_unstable]` attribute. Stability was previously implied if omitted; a follow-up PR is planned to change the fallback to be unstable.
Mark the panic_no_unwind lang item as nounwind This has 2 effects: - It helps LLVM when inlining since it doesn't need to generate landing pads for `panic_no_unwind`. - It makes it sound for a panic handler to unwind even if `PanicInfo::can_unwind` returns true. This will simply cause another panic once the unwind tries to go past the `panic_no_unwind` lang item. Eventually this will cause a stack overflow, which is safe.
@bors r+ rollup=never p=2 |
📌 Commit 4695c21 has been approved by |
⌛ Testing commit 4695c21 with merge 1b6ca9b200f0373e83a966d3840ce5376ca90ea6... |
💥 Test timed out |
Sun, 06 Feb 2022 13:35:44 GMT [RUSTC-TIMING] synstructure test:false 2.697 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (7b43cfc): comparison url. Summary: This benchmark run did not return any relevant results. 1 results were found to be statistically significant but too small to be relevant. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Successful merges:
const
#90998 (Require const stability attribute on all stable functions that areconst
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup