Skip to content

Fix documentation for is_X_feature_detected! #94095

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Feb 17, 2022

These are now properly documented for all architectures and the
stability attributes in the docs are now correctly displayed.

This addresses this comment by @ehuss: #90271 (comment)

cc @adamgemmell

These are now properly documented for all architectures and the
stability attributes in the docs are now correctly displayed.
@rust-highfive
Copy link
Contributor

r? @dtolnay

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2022
@dtolnay
Copy link
Member

dtolnay commented Feb 17, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 17, 2022

📌 Commit 2b3fa06 has been approved by dtolnay

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2022
@Amanieu
Copy link
Member Author

Amanieu commented Feb 17, 2022

This should be included in the beta cutoff for tomorrow.

@bors p=1

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 17, 2022
Fix documentation for is_X_feature_detected!

These are now properly documented for all architectures and the
stability attributes in the docs are now correctly displayed.

This addresses this comment by `@ehuss:` rust-lang#90271 (comment)

cc `@adamgemmell`
@bors
Copy link
Collaborator

bors commented Feb 18, 2022

⌛ Testing commit 2b3fa06 with merge f838a42...

@bors
Copy link
Collaborator

bors commented Feb 18, 2022

☀️ Test successful - checks-actions
Approved by: dtolnay
Pushing f838a42 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 18, 2022
@bors bors merged commit f838a42 into rust-lang:master Feb 18, 2022
@rustbot rustbot added this to the 1.60.0 milestone Feb 18, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f838a42): comparison url.

Summary: This benchmark run did not return any relevant results. 7 results were found to be statistically significant but too small to be relevant.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants