-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Classify BinaryHeap & LinkedList unit tests as such #94126
Conversation
r? @yaahc (rust-highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #94824) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm reassigning this PR because I'm taking a break from the review rotation for a little while. Thank you for your patience. r? rust-lang/libs |
@bors r+ rollup |
📌 Commit a3a5d83 has been approved by |
⌛ Testing commit a3a5d83 with merge 70d22763c74ed679957e72e1f36e0e60941977be... |
💔 Test failed - checks-actions |
The job Click to see the possible cause of the failure (guessed by this bot)
|
@bors retry waiting for selector search-settings timed out rustdoc-gui |
Rollup of 7 pull requests Successful merges: - rust-lang#94126 (Classify BinaryHeap & LinkedList unit tests as such) - rust-lang#96222 (Clarify docs for `from_raw_parts` on `Vec` and `String`) - rust-lang#96499 (Make it possible to write doctests for bootstrap) - rust-lang#96567 (Fix docs for u32 and i32 logs func) - rust-lang#96568 (std::fmt: Various fixes and improvements to documentation) - rust-lang#96571 (Add a bathroom stall to weird expressions test) - rust-lang#96610 (Update browser-ui-test version to 0.9.0) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
All but one of these so-called integration test case are unit tests, just like btree's were (#75531). In addition, reunite the unit tests of linked_list that were split off during #23104 because they needed to remain unit tests (they were later moved to the separate file they are in during #63207). The two sets could remain separate files, but I opted to merge them back together, more or less in the order they used to be, apart from one duplicate name
test_split_off
and one duplicate tiny functionlist_from
.