rustdoc-json: Better Header Type #94137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make ABI an enum, instead of being stringly typed - Replace Qualifier HashSet with 3 bools - Merge ABI field into header, as they always occor together
|
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing |
rustbot
added
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
I'm definitely a fan of this change |
|
📌 Commit 5f8a62d5c20bf48d58f8bb91c2f1c65edb82f40e has been approved by |
bors
added
S-waiting-on-bors
|
Maybe should have waited for tests to finish, but ah well, bors will fail if it does :P |
This comment has been minimized.
This comment has been minimized.
aDotInTheVoid
force-pushed
the
abi-enum
branch
from
5f8a62d to
fd5adef
Compare
|
This needs to be reapproved on the latest version |
|
@bors r+ |
|
📌 Commit fd5adef has been approved by |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 23, 2022
rustdoc-json: Better Header Type - Make ABI an enum, instead of being stringly typed - Replace Qualifier HashSet with 3 bools - Merge ABI field into header, as they always occor together r? `@CraftSpider` `@rustbot` modify labels: +A-rustdoc-json +T-rustdoc
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 23, 2022
…askrgr Rollup of 12 pull requests Successful merges: - rust-lang#94128 (rustdoc: several minor fixes) - rust-lang#94137 (rustdoc-json: Better Header Type) - rust-lang#94213 (fix names in feature(...) suggestion) - rust-lang#94240 (Suggest calling .display() on `PathBuf` too) - rust-lang#94253 (Use 2021 edition in ./x.py fmt) - rust-lang#94259 (Bump download-ci-llvm-stamp for llvm-nm inclusion) - rust-lang#94260 (Fix rustdoc infinite redirection generation) - rust-lang#94263 (Typo fix: Close inline-code backtick) - rust-lang#94264 (Fix typo.) - rust-lang#94271 (Miri: extend comments on downcast operation) - rust-lang#94280 (Rename `region_should_not_be_omitted` to `should_print_region`) - rust-lang#94285 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @CraftSpider
@rustbot modify labels: +A-rustdoc-json +T-rustdoc