trait system: comments and small nonfunctional changes #94215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 6a1f5ea has been approved by |
bors
added
S-waiting-on-bors
|
I think the title for this PR could be better if it described what is being done. “small nits” is probably not particularly useful when scanning the git history, for example. |
lcnr
changed the title
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#91192 (Some improvements to the async docs) - rust-lang#94143 (rustc_const_eval: adopt let else in more places) - rust-lang#94156 (Gracefully handle non-UTF-8 string slices when pretty printing) - rust-lang#94186 (Update pin_static_ref stabilization version.) - rust-lang#94189 (Implement LowerHex on Scalar to clean up their display in rustdoc) - rust-lang#94190 (Use Metadata::modified instead of FileTime::from_last_modification_ti…) - rust-lang#94203 (CTFE engine: Scalar: expose size-generic to_(u)int methods) - rust-lang#94211 (Better error if the user tries to do assignment ... else) - rust-lang#94215 (trait system: comments and small nonfunctional changes) - rust-lang#94220 (Correctly handle miniz_oxide extern crate declaration) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @nikomatsakis because of the leak-check check removal