[stable] 1.59.0 release #94224
Merged
[stable] 1.59.0 release #94224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup=never p=100 |
|
📌 Commit 2b5a2134fd90ade72ccddebda19425478b6cd49d has been approved by |
bors
added
S-waiting-on-bors
edmorley
reviewed
Feb 21, 2022
Mark-Simulacrum
force-pushed
the
stable-next
branch
3 times, most recently
from
705fe3b to
916fa0e
Compare
|
@bors r+ rollup=never p=100 |
|
📌 Commit 916fa0e56d08927893aa512a1ddb98c1c57b304a has been approved by |
|
⌛ Testing commit 916fa0e56d08927893aa512a1ddb98c1c57b304a with merge 65d097e8a5032686f314bce749f4369ee0f7d744... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry ci-mirrors dns failure |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
⌛ Testing commit 916fa0e56d08927893aa512a1ddb98c1c57b304a with merge 68d537105f48fea11d56c5ba19d9304282d19acf... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Probably due to the libc bump pulled in due to the backport of compiler-builtins, will need to investigate |
…roideabi` rlib I ran `./x.py dist --host= --target=armv7-linux-androideabi` before this diff: ``` $ nm build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/armv7-linux-androideabi/lib/libcompiler_builtins-3d9661a82c59c66a.rlib 2> /dev/null | grep __sync_fetch_and_add_4 | wc -l 2 ``` And after: ``` $ nm build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/armv7-linux-androideabi/lib/libcompiler_builtins-ffd2745070943321.rlib 2> /dev/null | grep __sync_fetch_and_add_4 | wc -l 1 ``` Fixes rust-lang#93310
This disables incremental compilation by default and adds a snippet to the compiler release notes explaining the rationale and encouraging testing.
Mark-Simulacrum
force-pushed
the
stable-next
branch
from
916fa0e to
6af5faf
Compare
|
@bors r+ rollup=never p=100 Dropped the libc bump, hopefully that's enough to get things passing again. |
|
📌 Commit 6af5faf has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in a few backports:
armv7-linux-androideabirlib #93436This also includes a fresh commit replicating the 1.52.1 patch soft-disabling incremental for 1.59, in light of discussion on #94124. This hasn't yet been fully approved but I think is the likely way things will go, so preparing the first round of stable artifacts with that in mind.
r? @Mark-Simulacrum